aboutsummaryrefslogtreecommitdiffstats
path: root/packages
diff options
context:
space:
mode:
authorAlex Browne <stephenalexbrowne@gmail.com>2018-08-09 05:23:52 +0800
committerGitHub <noreply@github.com>2018-08-09 05:23:52 +0800
commit19cda0eb036b6876964d8074aea1295142d25027 (patch)
treedaa7f91427e7bb70ed821f182fd315d0370ee4d4 /packages
parent13f0d27f7cf6fadacc01d013305975ce44af4482 (diff)
parent5ccf41c56693aa45988001260b68fdad2124b12c (diff)
downloaddexon-sol-tools-19cda0eb036b6876964d8074aea1295142d25027.tar
dexon-sol-tools-19cda0eb036b6876964d8074aea1295142d25027.tar.gz
dexon-sol-tools-19cda0eb036b6876964d8074aea1295142d25027.tar.bz2
dexon-sol-tools-19cda0eb036b6876964d8074aea1295142d25027.tar.lz
dexon-sol-tools-19cda0eb036b6876964d8074aea1295142d25027.tar.xz
dexon-sol-tools-19cda0eb036b6876964d8074aea1295142d25027.tar.zst
dexon-sol-tools-19cda0eb036b6876964d8074aea1295142d25027.zip
Merge pull request #947 from 0xProject/feature/confirm-before-publish
Add confirmation prompt before publishing
Diffstat (limited to 'packages')
-rw-r--r--packages/monorepo-scripts/src/publish.ts22
-rw-r--r--packages/monorepo-scripts/src/utils/utils.ts2
2 files changed, 15 insertions, 9 deletions
diff --git a/packages/monorepo-scripts/src/publish.ts b/packages/monorepo-scripts/src/publish.ts
index 5992131db..6ff0c9bef 100644
--- a/packages/monorepo-scripts/src/publish.ts
+++ b/packages/monorepo-scripts/src/publish.ts
@@ -31,12 +31,25 @@ const packageNameToWebsitePath: { [name: string]: string } = {
'ethereum-types': 'ethereum-types',
};
+async function confirmAsync(message: string): Promise<void> {
+ prompt.start();
+ const result = await promisify(prompt.get)([message]);
+ const didConfirm = result[message] === 'y';
+ if (!didConfirm) {
+ utils.log('Publish process aborted.');
+ process.exit(0);
+ }
+}
+
(async () => {
// Fetch public, updated Lerna packages
const shouldIncludePrivate = true;
const allUpdatedPackages = await utils.getUpdatedPackagesAsync(shouldIncludePrivate);
if (!configs.IS_LOCAL_PUBLISH) {
+ await confirmAsync(
+ 'THIS IS NOT A TEST PUBLISH! You are about to publish one or more packages to npm. Are you sure you want to continue? (y/n)',
+ );
await confirmDocPagesRenderAsync(allUpdatedPackages);
}
@@ -107,14 +120,7 @@ package.ts. Please add an entry for it and try again.`,
opn(link);
});
- prompt.start();
- const message = 'Do all the doc pages render properly? (yn)';
- const result = await promisify(prompt.get)([message]);
- const didConfirm = result[message] === 'y';
- if (!didConfirm) {
- utils.log('Publish process aborted.');
- process.exit(0);
- }
+ await confirmAsync('Do all the doc pages render properly? (y/n)');
}
async function pushChangelogsToGithubAsync(): Promise<void> {
diff --git a/packages/monorepo-scripts/src/utils/utils.ts b/packages/monorepo-scripts/src/utils/utils.ts
index d9bae3ea9..26ac801bd 100644
--- a/packages/monorepo-scripts/src/utils/utils.ts
+++ b/packages/monorepo-scripts/src/utils/utils.ts
@@ -117,7 +117,7 @@ export const utils = {
return tags;
},
async getLocalGitTagsAsync(): Promise<string[]> {
- const result = await execAsync(`git tags`, {
+ const result = await execAsync(`git tag`, {
cwd: constants.monorepoRootPath,
});
const tagsString = result.stdout;