diff options
| author | Jacob Evans <jacob@dekz.net> | 2018-10-17 11:14:48 +0800 |
|---|---|---|
| committer | Jacob Evans <jacob@dekz.net> | 2018-10-17 11:25:02 +0800 |
| commit | 0013bafc62571bc81f2984974c4893c3770b1786 (patch) | |
| tree | c91b7c52b7fefdbef42be419cc1075436b4d87a6 /packages | |
| parent | 72f5719b3412da7840a7b85e4dce512ecbaece4d (diff) | |
| download | dexon-sol-tools-0013bafc62571bc81f2984974c4893c3770b1786.tar dexon-sol-tools-0013bafc62571bc81f2984974c4893c3770b1786.tar.gz dexon-sol-tools-0013bafc62571bc81f2984974c4893c3770b1786.tar.bz2 dexon-sol-tools-0013bafc62571bc81f2984974c4893c3770b1786.tar.lz dexon-sol-tools-0013bafc62571bc81f2984974c4893c3770b1786.tar.xz dexon-sol-tools-0013bafc62571bc81f2984974c4893c3770b1786.tar.zst dexon-sol-tools-0013bafc62571bc81f2984974c4893c3770b1786.zip | |
fix(monorepo-scripts): Format date as UTC not local time.
Down under is in the future and causes many conflicts when formatting the timestamp in the local context. All previous releases jumped a day ahead. By setting this to UTC we will have consistent formatted dates in the changelogs no matter where one publishes from.
npm-cli-login fails on node 10 as a deprecation in node 9 has finished. This package appears to be unmaintained so we now have a fork with a fix
Diffstat (limited to 'packages')
| -rw-r--r-- | packages/monorepo-scripts/CHANGELOG.json | 9 | ||||
| -rw-r--r-- | packages/monorepo-scripts/src/utils/changelog_utils.ts | 3 |
2 files changed, 11 insertions, 1 deletions
diff --git a/packages/monorepo-scripts/CHANGELOG.json b/packages/monorepo-scripts/CHANGELOG.json index 3b8684fab..cf7a22bb7 100644 --- a/packages/monorepo-scripts/CHANGELOG.json +++ b/packages/monorepo-scripts/CHANGELOG.json @@ -1,5 +1,14 @@ [ { + "version": "1.0.6", + "changes": [ + { + "note": "Render date formats in UTC to prevent conflicts when publishing in different timezones.", + "pr": 1143 + } + ] + }, + { "timestamp": 1534210131, "version": "1.0.5", "changes": [ diff --git a/packages/monorepo-scripts/src/utils/changelog_utils.ts b/packages/monorepo-scripts/src/utils/changelog_utils.ts index 8058d222b..0b46bf670 100644 --- a/packages/monorepo-scripts/src/utils/changelog_utils.ts +++ b/packages/monorepo-scripts/src/utils/changelog_utils.ts @@ -19,7 +19,8 @@ CHANGELOG export const changelogUtils = { getChangelogMdTitle(versionChangelog: VersionChangelog): string { - const date = moment(`${versionChangelog.timestamp}`, 'X').format('MMMM D, YYYY'); + // Use UTC rather than the local machines time (formatted date time is +0:00) + const date = moment.utc(`${versionChangelog.timestamp}`, 'X').format('MMMM D, YYYY'); const title = `\n## v${versionChangelog.version} - _${date}_\n\n`; return title; }, |