aboutsummaryrefslogtreecommitdiffstats
path: root/packages/utils
diff options
context:
space:
mode:
authorFabio Berger <me@fabioberger.com>2019-01-11 07:47:57 +0800
committerFabio Berger <me@fabioberger.com>2019-01-11 07:47:57 +0800
commit583e690b7a028c85809a8be2c7afe3b65264adbe (patch)
treebc7ba2fe96833633455daaebf44d7382d0e20b7d /packages/utils
parenta516b00a0397a567fd233bd955206d46321cc178 (diff)
parenta5b7a351609a5e6689bb97990216153f64302462 (diff)
downloaddexon-sol-tools-583e690b7a028c85809a8be2c7afe3b65264adbe.tar
dexon-sol-tools-583e690b7a028c85809a8be2c7afe3b65264adbe.tar.gz
dexon-sol-tools-583e690b7a028c85809a8be2c7afe3b65264adbe.tar.bz2
dexon-sol-tools-583e690b7a028c85809a8be2c7afe3b65264adbe.tar.lz
dexon-sol-tools-583e690b7a028c85809a8be2c7afe3b65264adbe.tar.xz
dexon-sol-tools-583e690b7a028c85809a8be2c7afe3b65264adbe.tar.zst
dexon-sol-tools-583e690b7a028c85809a8be2c7afe3b65264adbe.zip
Merge branch 'development' into fix/dev-tools-pages/finalTouches
* development: (49 commits) upgrade to ddex api v3 (#1507) Add new deployment related instructions to pipeline README (#1499) feature: implement logging and friendly wallet name for Opera Fix prettier Add missing dependencies Remove second yarn call Add .gitkeep Rename sol-trace-based-tools-common to sol-tracing-utils Update packages/sol-trace/README.md Update packages/sol-trace/CHANGELOG.json Update packages/sol-trace-based-tools-common/src/source_maps.ts Update packages/sol-trace-based-tools-common/CHANGELOG.json Update packages/sol-profiler/CHANGELOG.json Update packages/sol-coverage/CHANGELOG.json Update packages/monorepo-scripts/src/test_installation.ts chore: changelog update fix: account for undefined errors in promisify, not only null Clean up docs before publish In README's, don't mention non-existent tests (#1497) fix: use getBackendBaseUrl instead of hardcoded string ...
Diffstat (limited to 'packages/utils')
-rw-r--r--packages/utils/CHANGELOG.json9
-rw-r--r--packages/utils/src/promisify.ts2
2 files changed, 10 insertions, 1 deletions
diff --git a/packages/utils/CHANGELOG.json b/packages/utils/CHANGELOG.json
index fb85c4174..d84e32dd2 100644
--- a/packages/utils/CHANGELOG.json
+++ b/packages/utils/CHANGELOG.json
@@ -1,5 +1,14 @@
[
{
+ "version": "3.0.0",
+ "changes": [
+ {
+ "note": "Make `promisify` resolve when the callback error is undefined.",
+ "pr": 1501
+ }
+ ]
+ },
+ {
"version": "2.1.1",
"changes": [
{
diff --git a/packages/utils/src/promisify.ts b/packages/utils/src/promisify.ts
index 29d626b61..e82251a0f 100644
--- a/packages/utils/src/promisify.ts
+++ b/packages/utils/src/promisify.ts
@@ -10,7 +10,7 @@ export function promisify<T>(originalFn: (...args: any[]) => void, thisArg?: any
const promisifiedFunction = async (...callArgs: any[]): Promise<T> => {
return new Promise<T>((resolve, reject) => {
const callback = (err: Error | null, data?: T) => {
- _.isNull(err) ? resolve(data) : reject(err);
+ _.isNull(err) || _.isUndefined(err) ? resolve(data) : reject(err);
};
originalFn.apply(thisArg, [...callArgs, callback]);
});