Merge branch 'v2-prototype' into bug/contracts/eip712-191-prefix

5 files changed, 7 insertions, 8 deletions

diff --git a/packages/testnet-faucets/package.json b/packages/testnet-faucets/package.json
index 06f8d3e84..2d1252596 100644
--- a/packages/testnet-faucets/package.json
+++ b/packages/testnet-faucets/package.json
@@ -8,7 +8,7 @@
     "description": "A faucet micro-service that dispenses test ERC20 tokens or Ether",
     "main": "server.js",
     "scripts": {
-        "watch": "tsc -w",
+        "watch_without_deps": "tsc -w",
         "build": "node ../../node_modules/gulp/bin/gulp.js build",
         "dev": "node ../../node_modules/gulp/bin/gulp.js run",
         "start": "node ./server/server.js",
diff --git a/packages/testnet-faucets/src/ts/dispense_asset_tasks.ts b/packages/testnet-faucets/src/ts/dispense_asset_tasks.ts
index 39ba4bc14..41b6c90cd 100644
--- a/packages/testnet-faucets/src/ts/dispense_asset_tasks.ts
+++ b/packages/testnet-faucets/src/ts/dispense_asset_tasks.ts
@@ -4,7 +4,6 @@ import * as _ from 'lodash';
 import * as Web3 from 'web3';
 
 import { configs } from './configs';
-import { errorReporter } from './error_reporter';
 
 const DISPENSE_AMOUNT_ETHER = 0.1;
 const DISPENSE_AMOUNT_TOKEN = 0.1;
diff --git a/packages/testnet-faucets/src/ts/handler.ts b/packages/testnet-faucets/src/ts/handler.ts
index 3a105742e..3a60d396c 100644
--- a/packages/testnet-faucets/src/ts/handler.ts
+++ b/packages/testnet-faucets/src/ts/handler.ts
@@ -1,4 +1,4 @@
-import { Order, SignedOrder, ZeroEx } from '0x.js';
+import { Order, ZeroEx } from '0x.js';
 import { BigNumber, logUtils } from '@0xproject/utils';
 import { Provider } from 'ethereum-types';
 import * as express from 'express';
@@ -71,9 +71,9 @@ export class Handler {
             };
         });
     }
-    public getQueueInfo(req: express.Request, res: express.Response): void {
+    public getQueueInfo(_req: express.Request, res: express.Response): void {
         res.setHeader('Content-Type', 'application/json');
-        const queueInfo = _.mapValues(rpcUrls, (rpcUrl: string, networkId: string) => {
+        const queueInfo = _.mapValues(rpcUrls, (_rpcUrl: string, networkId: string) => {
             const dispatchQueue = this._networkConfigByNetworkId[networkId].dispatchQueue;
             return {
                 full: dispatchQueue.isFull(),
@@ -95,7 +95,7 @@ export class Handler {
     public async dispenseZRXOrderAsync(
         req: express.Request,
         res: express.Response,
-        next: express.NextFunction,
+        _next: express.NextFunction,
     ): Promise<void> {
         await this._dispenseOrderAsync(req, res, RequestedAssetType.ZRX);
     }
@@ -171,7 +171,6 @@ export class Handler {
             ...order,
             ecSignature: signature,
         };
-        const signedOrderHash = ZeroEx.getOrderHashHex(signedOrder);
         const payload = JSON.stringify(signedOrder);
         logUtils.log(`Dispensed signed order: ${payload}`);
         res.status(constants.SUCCESS_STATUS).send(payload);
diff --git a/packages/testnet-faucets/src/ts/parameter_transformer.ts b/packages/testnet-faucets/src/ts/parameter_transformer.ts
index b9929a0d9..7320b1d1c 100644
--- a/packages/testnet-faucets/src/ts/parameter_transformer.ts
+++ b/packages/testnet-faucets/src/ts/parameter_transformer.ts
@@ -2,7 +2,6 @@ import { addressUtils } from '@0xproject/utils';
 import { NextFunction, Request, Response } from 'express';
 import * as _ from 'lodash';
 
-import { configs } from './configs';
 import { constants } from './constants';
 import { rpcUrls } from './rpc_urls';
 
diff --git a/packages/testnet-faucets/src/ts/server.ts b/packages/testnet-faucets/src/ts/server.ts
index 55c1d55d8..5416cdcc3 100644
--- a/packages/testnet-faucets/src/ts/server.ts
+++ b/packages/testnet-faucets/src/ts/server.ts
@@ -11,6 +11,7 @@ errorReporter.setup();
 
 const app = express();
 app.use(bodyParser.json()); // for parsing application/json
+// tslint:disable-next-line:no-unused-variable
 app.use((req, res, next) => {
     res.header('Access-Control-Allow-Origin', '*');
     res.header('Access-Control-Allow-Headers', 'Origin, X-Requested-With, Content-Type, Accept');
@@ -18,6 +19,7 @@ app.use((req, res, next) => {
 });
 
 const handler = new Handler();
+// tslint:disable-next-line:no-unused-variable
 app.get('/ping', (req: express.Request, res: express.Response) => {
     res.status(constants.SUCCESS_STATUS).send('pong');
 });