diff options
author | Brandon Millman <brandon.millman@gmail.com> | 2018-02-08 03:00:42 +0800 |
---|---|---|
committer | Brandon Millman <brandon.millman@gmail.com> | 2018-02-08 03:00:42 +0800 |
commit | 9ff4cacf0f9122c035537632d68169d7c2d5763f (patch) | |
tree | 6a27330cc3b1b2076e933a573312eaac2948b40b /packages/testnet-faucets/src/ts/dispense_asset_tasks.ts | |
parent | f3c6cce4559d096a2f3babfc7af670d078a6f0dd (diff) | |
download | dexon-sol-tools-9ff4cacf0f9122c035537632d68169d7c2d5763f.tar dexon-sol-tools-9ff4cacf0f9122c035537632d68169d7c2d5763f.tar.gz dexon-sol-tools-9ff4cacf0f9122c035537632d68169d7c2d5763f.tar.bz2 dexon-sol-tools-9ff4cacf0f9122c035537632d68169d7c2d5763f.tar.lz dexon-sol-tools-9ff4cacf0f9122c035537632d68169d7c2d5763f.tar.xz dexon-sol-tools-9ff4cacf0f9122c035537632d68169d7c2d5763f.tar.zst dexon-sol-tools-9ff4cacf0f9122c035537632d68169d7c2d5763f.zip |
Addressed review comments
Diffstat (limited to 'packages/testnet-faucets/src/ts/dispense_asset_tasks.ts')
-rw-r--r-- | packages/testnet-faucets/src/ts/dispense_asset_tasks.ts | 44 |
1 files changed, 17 insertions, 27 deletions
diff --git a/packages/testnet-faucets/src/ts/dispense_asset_tasks.ts b/packages/testnet-faucets/src/ts/dispense_asset_tasks.ts index c70458fbe..9aa47463c 100644 --- a/packages/testnet-faucets/src/ts/dispense_asset_tasks.ts +++ b/packages/testnet-faucets/src/ts/dispense_asset_tasks.ts @@ -15,40 +15,30 @@ export const dispenseAssetTasks = { return async () => { utils.consoleLog(`Processing ETH ${recipientAddress}`); const sendTransactionAsync = promisify(web3.eth.sendTransaction); - try { - const txHash = await sendTransactionAsync({ - from: configs.DISPENSER_ADDRESS, - to: recipientAddress, - value: web3.toWei(DISPENSE_AMOUNT_ETHER, 'ether'), - }); - utils.consoleLog(`Sent ${DISPENSE_AMOUNT_ETHER} ETH to ${recipientAddress} tx: ${txHash}`); - } catch (err) { - utils.consoleLog(`Unexpected err: ${err} - ${JSON.stringify(err)}`); - await errorReporter.reportAsync(err); - } + const txHash = await sendTransactionAsync({ + from: configs.DISPENSER_ADDRESS, + to: recipientAddress, + value: web3.toWei(DISPENSE_AMOUNT_ETHER, 'ether'), + }); + utils.consoleLog(`Sent ${DISPENSE_AMOUNT_ETHER} ETH to ${recipientAddress} tx: ${txHash}`); }; }, dispenseTokenTask(recipientAddress: string, tokenSymbol: string, zeroEx: ZeroEx) { return async () => { utils.consoleLog(`Processing ${tokenSymbol} ${recipientAddress}`); const amountToDispense = new BigNumber(DISPENSE_AMOUNT_TOKEN); - try { - const token = await zeroEx.tokenRegistry.getTokenBySymbolIfExistsAsync(tokenSymbol); - if (_.isUndefined(token)) { - throw new Error(`Unsupported asset type: ${tokenSymbol}`); - } - const baseUnitAmount = ZeroEx.toBaseUnitAmount(amountToDispense, token.decimals); - const txHash = await zeroEx.token.transferAsync( - token.address, - configs.DISPENSER_ADDRESS, - recipientAddress, - baseUnitAmount, - ); - utils.consoleLog(`Sent ${amountToDispense} ZRX to ${recipientAddress} tx: ${txHash}`); - } catch (err) { - utils.consoleLog(`Unexpected err: ${err} - ${JSON.stringify(err)}`); - await errorReporter.reportAsync(err); + const token = await zeroEx.tokenRegistry.getTokenBySymbolIfExistsAsync(tokenSymbol); + if (_.isUndefined(token)) { + throw new Error(`Unsupported asset type: ${tokenSymbol}`); } + const baseUnitAmount = ZeroEx.toBaseUnitAmount(amountToDispense, token.decimals); + const txHash = await zeroEx.token.transferAsync( + token.address, + configs.DISPENSER_ADDRESS, + recipientAddress, + baseUnitAmount, + ); + utils.consoleLog(`Sent ${amountToDispense} ZRX to ${recipientAddress} tx: ${txHash}`); }; }, }; |