Merge branch 'development' into dev-section-redesign

* development: (62 commits)
  Fix linter error
  Upgrade ethereum-types
  Lint and update deps
  Be more explicit with falsiness
  Add type to cssRuleIfExists
  Fix issue where we throw if non-numeric characters are used in input
  Upgrade to more recent types, fix yarn.lock
  [fix]: [testnet-faucet] Exit 1 on build fail
  Explains tools we want them to use
  Add note about button
  Add dev-tools-pages bundles to gitignore
  Improve README
  Fix button and center
  Increase max bundle size for instant
  Add stuff
  Initial project scaffolding
  Change tslint config to remove conflicts with prettier
  fix: [testnet-faucet] Signing of orders
  Update the CHANGELOG
  Add comments for expiryBuffer
  ...

1 files changed, 17 insertions, 18 deletions

diff --git a/packages/testnet-faucets/gulpfile.js b/packages/testnet-faucets/gulpfile.js
index 7c4e25e0f..839ef851b 100644
--- a/packages/testnet-faucets/gulpfile.js
+++ b/packages/testnet-faucets/gulpfile.js
@@ -14,10 +14,7 @@ const config = {
     },
     devtool: 'source-map',
     resolve: {
-        modules: [
-            path.join(__dirname, '/src/ts'),
-            'node_modules',
-        ],
+        modules: [path.join(__dirname, '/src/ts'), 'node_modules'],
         extensions: ['.ts', '.tsx', '.js', '.jsx', '.json'],
         alias: {
             ts: path.join(__dirname, '/src/ts'),
@@ -44,10 +41,10 @@ const config = {
         }),
     ],
     externals: nodeExternals({
-        modulesDir: path.join(__dirname, '../../node_modules')
+        modulesDir: path.join(__dirname, '../../node_modules'),
     }),
     watchOptions: {
-        ignored: /server|node_modules|transpiled/
+        ignored: /server|node_modules|transpiled/,
     },
 };
 
@@ -77,16 +74,18 @@ gulp.task('run', ['watch'], function() {
 });
 
 function onBuild(done) {
-  return function(err, stats) {
-    if(err) {
-      console.log('Error', err);
-    }
-    else {
-      console.log(stats.toString());
-    }
-
-    if(done) {
-      done();
-    }
-  }
+    return function(err, stats) {
+        if (err) {
+            console.log('Error', err);
+            process.exit(1);
+        } else {
+            console.log(stats.toString());
+        }
+        if (done) {
+            if (stats.compilation.errors && stats.compilation.errors.length > 0) {
+                process.exit(1);
+            }
+            done();
+        }
+    };
 }