diff options
| author | Jacob Evans <dekz@dekz.net> | 2018-04-26 13:44:55 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-04-26 13:44:55 +0800 |
| commit | 47604384d4042c3c61f29a635491f8165236e763 (patch) | |
| tree | 195d310c7bd59c20a759b4267963e7e357721460 /packages/subproviders | |
| parent | c69984e309404e60a71f4b739f46abdc25c87584 (diff) | |
| parent | 5682cd0048072fd5c420a35170045134bc5185b9 (diff) | |
| download | dexon-sol-tools-47604384d4042c3c61f29a635491f8165236e763.tar dexon-sol-tools-47604384d4042c3c61f29a635491f8165236e763.tar.gz dexon-sol-tools-47604384d4042c3c61f29a635491f8165236e763.tar.bz2 dexon-sol-tools-47604384d4042c3c61f29a635491f8165236e763.tar.lz dexon-sol-tools-47604384d4042c3c61f29a635491f8165236e763.tar.xz dexon-sol-tools-47604384d4042c3c61f29a635491f8165236e763.tar.zst dexon-sol-tools-47604384d4042c3c61f29a635491f8165236e763.zip | |
Merge pull request #555 from 0xProject/feature/subproviders/upgrade-provider-engine
Update Web3 Provider Engine to 14.0.4
Diffstat (limited to 'packages/subproviders')
| -rw-r--r-- | packages/subproviders/CHANGELOG.json | 13 | ||||
| -rw-r--r-- | packages/subproviders/package.json | 2 | ||||
| -rw-r--r-- | packages/subproviders/src/subproviders/base_wallet_subprovider.ts | 5 |
3 files changed, 17 insertions, 3 deletions
diff --git a/packages/subproviders/CHANGELOG.json b/packages/subproviders/CHANGELOG.json index d3ba7a928..5055f1f65 100644 --- a/packages/subproviders/CHANGELOG.json +++ b/packages/subproviders/CHANGELOG.json @@ -1,5 +1,18 @@ [ { + "version": "0.10.0", + "changes": [ + { + "note": "Upgrade web3-provider-engine to 14.0.4", + "pr": 555 + }, + { + "note": "Relax `to` validation in base wallet subprovider for transactions that deploy contracts", + "pr": 555 + } + ] + }, + { "version": "0.9.0", "changes": [ { diff --git a/packages/subproviders/package.json b/packages/subproviders/package.json index aaa0f657c..d504397b0 100644 --- a/packages/subproviders/package.json +++ b/packages/subproviders/package.json @@ -51,7 +51,7 @@ "lodash": "^4.17.4", "semaphore-async-await": "^1.5.1", "web3": "^0.20.0", - "web3-provider-engine": "^13.0.1" + "web3-provider-engine": "^14.0.4" }, "devDependencies": { "@0xproject/monorepo-scripts": "^0.1.18", diff --git a/packages/subproviders/src/subproviders/base_wallet_subprovider.ts b/packages/subproviders/src/subproviders/base_wallet_subprovider.ts index 0a9b99ae4..f68d7eb29 100644 --- a/packages/subproviders/src/subproviders/base_wallet_subprovider.ts +++ b/packages/subproviders/src/subproviders/base_wallet_subprovider.ts @@ -9,9 +9,10 @@ import { Subprovider } from './subprovider'; export abstract class BaseWalletSubprovider extends Subprovider { protected static _validateTxParams(txParams: PartialTxParams) { - assert.isETHAddressHex('to', txParams.to); + if (!_.isUndefined(txParams.to)) { + assert.isETHAddressHex('to', txParams.to); + } assert.isHexString('nonce', txParams.nonce); - assert.isHexString('gas', txParams.gas); } private static _validateSender(sender: string) { if (_.isUndefined(sender) || !addressUtils.isAddress(sender)) { |