diff options
author | Brandon Millman <brandon@0xproject.com> | 2018-03-15 06:30:59 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-03-15 06:30:59 +0800 |
commit | 4a27a7dc581fc6c8a3d4e212ca3712c249a5b417 (patch) | |
tree | 344bd9cb3391a7a0cfb726cc7a54f4694eabd974 /packages/sra-report | |
parent | aea7207b9f9865a279243889a5f9ca1638ddc739 (diff) | |
parent | 3b3d5b12bc78b13860504b9699fd5f15ae8813a1 (diff) | |
download | dexon-sol-tools-4a27a7dc581fc6c8a3d4e212ca3712c249a5b417.tar dexon-sol-tools-4a27a7dc581fc6c8a3d4e212ca3712c249a5b417.tar.gz dexon-sol-tools-4a27a7dc581fc6c8a3d4e212ca3712c249a5b417.tar.bz2 dexon-sol-tools-4a27a7dc581fc6c8a3d4e212ca3712c249a5b417.tar.lz dexon-sol-tools-4a27a7dc581fc6c8a3d4e212ca3712c249a5b417.tar.xz dexon-sol-tools-4a27a7dc581fc6c8a3d4e212ca3712c249a5b417.tar.zst dexon-sol-tools-4a27a7dc581fc6c8a3d4e212ca3712c249a5b417.zip |
Merge pull request #452 from 0xProject/feature/utils/console-log
Consolidate all console.log utils into @0xproject/utils
Diffstat (limited to 'packages/sra-report')
-rw-r--r-- | packages/sra-report/CHANGELOG.md | 4 | ||||
-rw-r--r-- | packages/sra-report/src/index.ts | 11 | ||||
-rw-r--r-- | packages/sra-report/src/postman_environment_factory.ts | 4 | ||||
-rw-r--r-- | packages/sra-report/src/utils.ts | 5 |
4 files changed, 11 insertions, 13 deletions
diff --git a/packages/sra-report/CHANGELOG.md b/packages/sra-report/CHANGELOG.md index 43b92d58a..ede98a60f 100644 --- a/packages/sra-report/CHANGELOG.md +++ b/packages/sra-report/CHANGELOG.md @@ -1,3 +1,7 @@ # CHANGELOG +## v0.0.2 - _TBD, 2018_ + + * Consolidate all `console.log` calls into `logUtils` in the `@0xproject/utils` package (#452) + ## v0.0.1 - _March 8, 2018_ diff --git a/packages/sra-report/src/index.ts b/packages/sra-report/src/index.ts index d23549916..e9d55ab9b 100644 --- a/packages/sra-report/src/index.ts +++ b/packages/sra-report/src/index.ts @@ -1,7 +1,7 @@ #!/usr/bin/env node import { assert } from '@0xproject/assert'; import { Schema, schemas } from '@0xproject/json-schemas'; -import { promisify } from '@0xproject/utils'; +import { logUtils, promisify } from '@0xproject/utils'; import chalk from 'chalk'; import * as _ from 'lodash'; import * as newman from 'newman'; @@ -10,7 +10,6 @@ import * as yargs from 'yargs'; import * as sraReportCollectionJSON from '../postman_configs/collections/sra_report.postman_collection.json'; import { postmanEnvironmentFactory } from './postman_environment_factory'; -import { utils } from './utils'; const newmanRunAsync = promisify<void>(newman.run); const DEFAULT_NETWORK_ID = 1; @@ -66,12 +65,12 @@ const args = yargs try { assert.isWebUri('args', args.endpointUrl); } catch (err) { - utils.log(`${chalk.red(`Invalid url format:`)} ${args.endpointUrl}`); + logUtils.log(`${chalk.red(`Invalid url format:`)} ${args.endpointUrl}`); process.exit(1); } if (!_.includes(SUPPORTED_NETWORK_IDS, args.networkId)) { - utils.log(`${chalk.red(`Unsupported network id:`)} ${args.networkId}`); - utils.log(`${chalk.bold(`Supported network ids:`)} ${SUPPORTED_NETWORK_IDS}`); + logUtils.log(`${chalk.red(`Unsupported network id:`)} ${args.networkId}`); + logUtils.log(`${chalk.bold(`Supported network ids:`)} ${SUPPORTED_NETWORK_IDS}`); process.exit(1); } const mainAsync = async () => { @@ -99,4 +98,4 @@ const mainAsync = async () => { }; await newmanRunAsync(newmanRunOptions); }; -mainAsync().catch(utils.log); +mainAsync().catch(logUtils.log); diff --git a/packages/sra-report/src/postman_environment_factory.ts b/packages/sra-report/src/postman_environment_factory.ts index ffac7ac2e..530cacb07 100644 --- a/packages/sra-report/src/postman_environment_factory.ts +++ b/packages/sra-report/src/postman_environment_factory.ts @@ -1,6 +1,7 @@ import { SignedOrder, ZeroEx } from '0x.js'; import { HttpClient } from '@0xproject/connect'; import { Schema, schemas as schemasByName } from '@0xproject/json-schemas'; +import { logUtils } from '@0xproject/utils'; import chalk from 'chalk'; import * as _ from 'lodash'; @@ -8,7 +9,6 @@ import { addresses as kovanAddresses } from './contract_addresses/kovan_addresse import { addresses as mainnetAddresses } from './contract_addresses/mainnet_addresses'; import { addresses as rinkebyAddresses } from './contract_addresses/rinkeby_addresses'; import { addresses as ropstenAddresses } from './contract_addresses/ropsten_addresses'; -import { utils } from './utils'; const ENVIRONMENT_NAME = 'SRA Report'; @@ -81,7 +81,7 @@ async function createOrderEnvironmentValuesAsync(url: string) { createEnvironmentValue('orderHash', ZeroEx.getOrderHashHex(orderIfExists)), ]; } else { - utils.log(`${chalk.red(`No orders from /orders found`)}`); + logUtils.log(`${chalk.red(`No orders from /orders found`)}`); return [ createEnvironmentValue('order', ''), createEnvironmentValue('orderMaker', ''), diff --git a/packages/sra-report/src/utils.ts b/packages/sra-report/src/utils.ts deleted file mode 100644 index 5423cabd9..000000000 --- a/packages/sra-report/src/utils.ts +++ /dev/null @@ -1,5 +0,0 @@ -export const utils = { - log(...args: any[]): void { - console.log(...args); // tslint:disable-line:no-console - }, -}; |