Address PR feedback

4 files changed, 31 insertions, 28 deletions

diff --git a/packages/pipeline/src/scripts/pull_missing_blocks.ts b/packages/pipeline/src/scripts/pull_missing_blocks.ts
index 4a1483ab9..b7bd51f08 100644
--- a/packages/pipeline/src/scripts/pull_missing_blocks.ts
+++ b/packages/pipeline/src/scripts/pull_missing_blocks.ts
@@ -9,7 +9,7 @@ import { Web3Source } from '../data_sources/web3';
 import { Block } from '../entities';
 import * as ormConfig from '../ormconfig';
 import { parseBlock } from '../parsers/web3';
-import { handleError } from '../utils';
+import { EXCHANGE_START_BLOCK, handleError, INFURA_ROOT_URL } from '../utils';
 
 // Number of blocks to save at once.
 const BATCH_SAVE_SIZE = 1000;
@@ -18,16 +18,13 @@ const MAX_CONCURRENCY = 10;
 // Maximum number of blocks to query for at once. This is also the maximum
 // number of blocks we will hold in memory prior to being saved to the database.
 const MAX_BLOCKS_PER_QUERY = 1000;
-// Block number when the Exchange contract was deployed to mainnet.
-// TODO(albrow): De-dupe this constant.
-const EXCHANGE_START_BLOCK = 6271590;
 
 let connection: Connection;
 
 (async () => {
     connection = await createConnection(ormConfig as ConnectionOptions);
     const provider = web3Factory.getRpcProvider({
-        rpcUrl: `https://mainnet.infura.io/${process.env.INFURA_API_KEY}`,
+        rpcUrl: `${INFURA_ROOT_URL}/${process.env.INFURA_API_KEY}`,
     });
     const web3Source = new Web3Source(provider);
     await getAllMissingBlocks(web3Source);
diff --git a/packages/pipeline/src/scripts/pull_missing_events.ts b/packages/pipeline/src/scripts/pull_missing_events.ts
index c7e07c540..80abbb8b0 100644
--- a/packages/pipeline/src/scripts/pull_missing_events.ts
+++ b/packages/pipeline/src/scripts/pull_missing_events.ts
@@ -8,9 +8,8 @@ import { ExchangeEventsSource } from '../data_sources/contract-wrappers/exchange
 import { ExchangeCancelEvent, ExchangeCancelUpToEvent, ExchangeEvent, ExchangeFillEvent } from '../entities';
 import * as ormConfig from '../ormconfig';
 import { parseExchangeCancelEvents, parseExchangeCancelUpToEvents, parseExchangeFillEvents } from '../parsers/events';
-import { handleError } from '../utils';
+import { EXCHANGE_START_BLOCK, handleError, INFURA_ROOT_URL } from '../utils';
 
-const EXCHANGE_START_BLOCK = 6271590; // Block number when the Exchange contract was deployed to mainnet.
 const START_BLOCK_OFFSET = 100; // Number of blocks before the last known block to consider when updating fill events.
 const BATCH_SAVE_SIZE = 1000; // Number of events to save at once.
 
@@ -19,7 +18,7 @@ let connection: Connection;
 (async () => {
     connection = await createConnection(ormConfig as ConnectionOptions);
     const provider = web3Factory.getRpcProvider({
-        rpcUrl: 'https://mainnet.infura.io',
+        rpcUrl: INFURA_ROOT_URL,
     });
     const eventsSource = new ExchangeEventsSource(provider, 1);
     await getFillEventsAsync(eventsSource);
diff --git a/packages/pipeline/src/scripts/pull_radar_relay_orders.ts b/packages/pipeline/src/scripts/pull_radar_relay_orders.ts
index b3a4d887e..bbbef9b47 100644
--- a/packages/pipeline/src/scripts/pull_radar_relay_orders.ts
+++ b/packages/pipeline/src/scripts/pull_radar_relay_orders.ts
@@ -16,11 +16,11 @@ let connection: Connection;
 
 (async () => {
     connection = await createConnection(ormConfig as ConnectionOptions);
-    await getOrderbook();
+    await getOrderbookAsync();
     process.exit(0);
 })().catch(handleError);
 
-async function getOrderbook(): Promise<void> {
+async function getOrderbookAsync(): Promise<void> {
     console.log('Getting all orders...');
     const connectClient = new HttpClient(RADAR_RELAY_URL);
     const rawOrders = await connectClient.getOrdersAsync({
@@ -29,17 +29,22 @@ async function getOrderbook(): Promise<void> {
     console.log(`Got ${rawOrders.records.length} orders.`);
     console.log('Parsing orders...');
     // Parse the sra orders, then add source url to each.
-    const orders = R.pipe(parseSraOrders, R.map(setSourceUrl(RADAR_RELAY_URL)))(rawOrders);
+    const orders = R.pipe(
+        parseSraOrders,
+        R.map(setSourceUrl(RADAR_RELAY_URL)),
+    )(rawOrders);
     // Save all the orders and update the observed time stamps in a single
     // transaction.
     console.log('Saving orders and updating timestamps...');
-    await connection.transaction(async (manager: EntityManager): Promise<void> => {
-        for (const order of orders) {
-            await manager.save(SraOrder, order);
-            const observedTimestamp = createObservedTimestampForOrder(order);
-            await manager.save(observedTimestamp);
-        }
-    });
+    await connection.transaction(
+        async (manager: EntityManager): Promise<void> => {
+            for (const order of orders) {
+                await manager.save(SraOrder, order);
+                const observedTimestamp = createObservedTimestampForOrder(order);
+                await manager.save(observedTimestamp);
+            }
+        },
+    );
 }
 
 const sourceUrlProp = R.lensProp('sourceUrl');
@@ -48,6 +53,8 @@ const sourceUrlProp = R.lensProp('sourceUrl');
  * Sets the source url for a single order. Returns a new order instead of
  * mutating the given one.
  */
-const setSourceUrl = R.curry((sourceURL: string, order: SraOrder): SraOrder => {
-    return R.set(sourceUrlProp, sourceURL, order);
-});
+const setSourceUrl = R.curry(
+    (sourceURL: string, order: SraOrder): SraOrder => {
+        return R.set(sourceUrlProp, sourceURL, order);
+    },
+);
diff --git a/packages/pipeline/src/scripts/pull_trusted_tokens.ts b/packages/pipeline/src/scripts/pull_trusted_tokens.ts
index b3a4466bb..1befc4437 100644
--- a/packages/pipeline/src/scripts/pull_trusted_tokens.ts
+++ b/packages/pipeline/src/scripts/pull_trusted_tokens.ts
@@ -8,7 +8,7 @@ import { parseMetamaskTrustedTokens, parseZeroExTrustedTokens } from '../parsers
 import { handleError } from '../utils';
 
 const METAMASK_TRUSTED_TOKENS_URL =
-    'https://raw.githubusercontent.com/MetaMask/eth-contract-metadata/master/contract-map.json';
+    'https://raw.githubusercontent.com/MetaMask/eth-contract-metadata/d45916c533116510cc8e9e048a8b5fc3732a6b6d/contract-map.json';
 
 const ZEROEX_TRUSTED_TOKENS_URL = 'https://website-api.0xproject.com/tokens';
 
@@ -22,7 +22,7 @@ let connection: Connection;
 })().catch(handleError);
 
 async function getMetamaskTrustedTokens(): Promise<void> {
-    // tslint:disable-next-line
+    // tslint:disable-next-line:no-console
     console.log('Getting latest metamask trusted tokens list ...');
     const trustedTokensRepository = connection.getRepository(TokenMetadata);
     const trustedTokensSource = new TrustedTokenSource<Map<string, MetamaskTrustedTokenMeta>>(
@@ -30,23 +30,23 @@ async function getMetamaskTrustedTokens(): Promise<void> {
     );
     const resp = await trustedTokensSource.getTrustedTokenMetaAsync();
     const trustedTokens = parseMetamaskTrustedTokens(resp);
-    // tslint:disable-next-line
+    // tslint:disable-next-line:no-console
     console.log('Saving metamask trusted tokens list');
     await trustedTokensRepository.save(trustedTokens);
-    // tslint:disable-next-line
+    // tslint:disable-next-line:no-console
     console.log('Done saving metamask trusted tokens.');
 }
 
 async function getZeroExTrustedTokens(): Promise<void> {
-    // tslint:disable-next-line
+    // tslint:disable-next-line:no-console
     console.log('Getting latest 0x trusted tokens list ...');
     const trustedTokensRepository = connection.getRepository(TokenMetadata);
     const trustedTokensSource = new TrustedTokenSource<ZeroExTrustedTokenMeta[]>(ZEROEX_TRUSTED_TOKENS_URL);
     const resp = await trustedTokensSource.getTrustedTokenMetaAsync();
     const trustedTokens = parseZeroExTrustedTokens(resp);
-    // tslint:disable-next-line
+    // tslint:disable-next-line:no-console
     console.log('Saving metamask trusted tokens list');
     await trustedTokensRepository.save(trustedTokens);
-    // tslint:disable-next-line
+    // tslint:disable-next-line:no-console
     console.log('Done saving metamask trusted tokens.');
 }