diff options
author | Alex Browne <stephenalexbrowne@gmail.com> | 2018-12-05 12:04:08 +0800 |
---|---|---|
committer | Fred Carlsen <fred@sjelfull.no> | 2018-12-13 01:18:56 +0800 |
commit | e1d77d6e101ad1c1eabbecfdc10b10d7ea2f9df8 (patch) | |
tree | 61a906c2b84406febc142f0575e7f24bfe891a0b /packages/pipeline/src/entities | |
parent | da51f6e56f0a0d90ef0abedc25b163b6445b73bb (diff) | |
download | dexon-sol-tools-e1d77d6e101ad1c1eabbecfdc10b10d7ea2f9df8.tar dexon-sol-tools-e1d77d6e101ad1c1eabbecfdc10b10d7ea2f9df8.tar.gz dexon-sol-tools-e1d77d6e101ad1c1eabbecfdc10b10d7ea2f9df8.tar.bz2 dexon-sol-tools-e1d77d6e101ad1c1eabbecfdc10b10d7ea2f9df8.tar.lz dexon-sol-tools-e1d77d6e101ad1c1eabbecfdc10b10d7ea2f9df8.tar.xz dexon-sol-tools-e1d77d6e101ad1c1eabbecfdc10b10d7ea2f9df8.tar.zst dexon-sol-tools-e1d77d6e101ad1c1eabbecfdc10b10d7ea2f9df8.zip |
Address PR feedback
Diffstat (limited to 'packages/pipeline/src/entities')
4 files changed, 0 insertions, 9 deletions
diff --git a/packages/pipeline/src/entities/exchange_cancel_event.ts b/packages/pipeline/src/entities/exchange_cancel_event.ts index 2fcc17df6..38f99c903 100644 --- a/packages/pipeline/src/entities/exchange_cancel_event.ts +++ b/packages/pipeline/src/entities/exchange_cancel_event.ts @@ -48,6 +48,4 @@ export class ExchangeCancelEvent { public takerTokenAddress!: string; @Column({ nullable: true, type: String, name: 'taker_token_id' }) public takerTokenId!: string | null; - - // TODO(albrow): Include topics? } diff --git a/packages/pipeline/src/entities/exchange_cancel_up_to_event.ts b/packages/pipeline/src/entities/exchange_cancel_up_to_event.ts index 60ead324f..27580305e 100644 --- a/packages/pipeline/src/entities/exchange_cancel_up_to_event.ts +++ b/packages/pipeline/src/entities/exchange_cancel_up_to_event.ts @@ -12,7 +12,6 @@ export class ExchangeCancelUpToEvent { @PrimaryColumn({ name: 'block_number', transformer: numberToBigIntTransformer }) public blockNumber!: number; - // TODO(albrow): Include transaction hash @Column({ name: 'raw_data' }) public rawData!: string; @@ -24,5 +23,4 @@ export class ExchangeCancelUpToEvent { public senderAddress!: string; @Column({ name: 'order_epoch', type: 'numeric', transformer: bigNumberTransformer }) public orderEpoch!: BigNumber; - // TODO(albrow): Include topics? } diff --git a/packages/pipeline/src/entities/exchange_fill_event.ts b/packages/pipeline/src/entities/exchange_fill_event.ts index bbf0abf58..9b7727615 100644 --- a/packages/pipeline/src/entities/exchange_fill_event.ts +++ b/packages/pipeline/src/entities/exchange_fill_event.ts @@ -57,6 +57,4 @@ export class ExchangeFillEvent { public takerTokenAddress!: string; @Column({ nullable: true, type: String, name: 'taker_token_id' }) public takerTokenId!: string | null; - - // TODO(albrow): Include topics? } diff --git a/packages/pipeline/src/entities/relayer.ts b/packages/pipeline/src/entities/relayer.ts index b3a856fd8..5af8578b4 100644 --- a/packages/pipeline/src/entities/relayer.ts +++ b/packages/pipeline/src/entities/relayer.ts @@ -14,9 +14,6 @@ export class Relayer { @Column({ name: 'app_url', type: 'varchar', nullable: true }) public appUrl!: string | null; - // TODO(albrow): Add exchange contract or protocol version? - // TODO(albrow): Add network ids for addresses? - @Column({ name: 'fee_recipient_addresses', type: 'varchar', array: true }) public feeRecipientAddresses!: string[]; @Column({ name: 'taker_addresses', type: 'varchar', array: true }) |