diff options
| author | fragosti <francesco.agosti93@gmail.com> | 2018-08-10 06:57:12 +0800 |
|---|---|---|
| committer | fragosti <francesco.agosti93@gmail.com> | 2018-08-10 06:57:12 +0800 |
| commit | 938a99f435ca01853ecb31f9267e2ba4b501d206 (patch) | |
| tree | 6b1aea79d1130206f6f69b68e0747c87616f2fb6 /packages/order-utils | |
| parent | b2c666bb1f2830211db208ba8398f2de799c8ee6 (diff) | |
| parent | f97ec000e109341f7b200d0ff9ff324bf3f97d3e (diff) | |
| download | dexon-sol-tools-938a99f435ca01853ecb31f9267e2ba4b501d206.tar dexon-sol-tools-938a99f435ca01853ecb31f9267e2ba4b501d206.tar.gz dexon-sol-tools-938a99f435ca01853ecb31f9267e2ba4b501d206.tar.bz2 dexon-sol-tools-938a99f435ca01853ecb31f9267e2ba4b501d206.tar.lz dexon-sol-tools-938a99f435ca01853ecb31f9267e2ba4b501d206.tar.xz dexon-sol-tools-938a99f435ca01853ecb31f9267e2ba4b501d206.tar.zst dexon-sol-tools-938a99f435ca01853ecb31f9267e2ba4b501d206.zip | |
Merge branch 'development' of https://github.com/0xProject/0x-monorepo into feature/sra/add-sra-package
Diffstat (limited to 'packages/order-utils')
| -rw-r--r-- | packages/order-utils/CHANGELOG.json | 3 | ||||
| -rw-r--r-- | packages/order-utils/package.json | 4 | ||||
| -rw-r--r-- | packages/order-utils/test/signature_utils_test.ts | 3 |
3 files changed, 7 insertions, 3 deletions
diff --git a/packages/order-utils/CHANGELOG.json b/packages/order-utils/CHANGELOG.json index 776bd67ec..fa82976ad 100644 --- a/packages/order-utils/CHANGELOG.json +++ b/packages/order-utils/CHANGELOG.json @@ -10,6 +10,9 @@ { "note": "Added marketUtils", "pr": 937 + }, + { + "note": "Dependencies updated" } ] }, diff --git a/packages/order-utils/package.json b/packages/order-utils/package.json index 7880b9352..98cbba0e1 100644 --- a/packages/order-utils/package.json +++ b/packages/order-utils/package.json @@ -64,7 +64,7 @@ "copyfiles": "^1.2.0", "dirty-chai": "^2.0.1", "make-promises-safe": "^1.1.0", - "mocha": "^4.0.1", + "mocha": "^4.1.0", "npm-run-all": "^4.1.2", "shx": "^0.2.2", "sinon": "^4.0.0", @@ -87,7 +87,7 @@ "ethereumjs-abi": "0.6.5", "ethereumjs-util": "^5.1.1", "ethers": "3.0.22", - "lodash": "^4.17.4" + "lodash": "^4.17.5" }, "publishConfig": { "access": "public" diff --git a/packages/order-utils/test/signature_utils_test.ts b/packages/order-utils/test/signature_utils_test.ts index 5714f9671..baae2b414 100644 --- a/packages/order-utils/test/signature_utils_test.ts +++ b/packages/order-utils/test/signature_utils_test.ts @@ -22,7 +22,8 @@ describe('Signature utils', () => { let address = '0x5409ed021d9299bf6814279a6a1411a7e866a631'; it("should return false if the data doesn't pertain to the signature & address", async () => { - expect(await isValidSignatureAsync(provider, '0x0', ethSignSignature, address)).to.be.false(); + const bytes32Zeros = '0x0000000000000000000000000000000000000000000000000000000000000000'; + expect(await isValidSignatureAsync(provider, bytes32Zeros, ethSignSignature, address)).to.be.false(); }); it("should return false if the address doesn't pertain to the signature & data", async () => { const validUnrelatedAddress = '0x8b0292b11a196601ed2ce54b665cafeca0347d42'; |