Merge branch 'development' of https://github.com/0xProject/0x-monorepo into website/feature/react-16

6 files changed, 12 insertions, 11 deletions

diff --git a/packages/monorepo-scripts/package.json b/packages/monorepo-scripts/package.json
index 6a4d0bb45..a2f2343b8 100644
--- a/packages/monorepo-scripts/package.json
+++ b/packages/monorepo-scripts/package.json
@@ -1,7 +1,7 @@
 {
     "private": true,
     "name": "@0xproject/monorepo-scripts",
-    "version": "1.0.6",
+    "version": "1.0.7",
     "engines": {
         "node": ">=6.12"
     },
diff --git a/packages/monorepo-scripts/src/doc_gen_configs.ts b/packages/monorepo-scripts/src/doc_gen_configs.ts
index 6d7560943..102b5d7ca 100644
--- a/packages/monorepo-scripts/src/doc_gen_configs.ts
+++ b/packages/monorepo-scripts/src/doc_gen_configs.ts
@@ -39,6 +39,7 @@ export const docGenConfigs: DocGenConfigs = {
         'EtherTokenWrapper',
         'ExchangeWrapper',
         'ForwarderWrapper',
+        'OrderValidatorWrapper',
         'TransactionEncoder',
     ],
     // Some types are not explicitly part of the public interface like params, return values, etc... But we still
diff --git a/packages/monorepo-scripts/src/publish.ts b/packages/monorepo-scripts/src/publish.ts
index 7e2e64536..646818c58 100644
--- a/packages/monorepo-scripts/src/publish.ts
+++ b/packages/monorepo-scripts/src/publish.ts
@@ -74,9 +74,11 @@ async function confirmAsync(message: string): Promise<void> {
     });
     utils.log(`Calling 'lerna publish'...`);
     await lernaPublishAsync(packageToNextVersion);
-    const isStaging = false;
-    const shouldUploadDocs = !configs.IS_LOCAL_PUBLISH;
-    await generateAndUploadDocJsonsAsync(packagesWithDocs, isStaging, shouldUploadDocs);
+    if (!configs.IS_LOCAL_PUBLISH) {
+        const isStaging = false;
+        const shouldUploadDocs = true;
+        await generateAndUploadDocJsonsAsync(packagesWithDocs, isStaging, shouldUploadDocs);
+    }
     const isDryRun = configs.IS_LOCAL_PUBLISH;
     await publishReleaseNotesAsync(updatedPublicPackages, isDryRun);
 })().catch(err => {
diff --git a/packages/monorepo-scripts/src/publish_release_notes.ts b/packages/monorepo-scripts/src/publish_release_notes.ts
index 13cf0d85d..a9bc8fe75 100644
--- a/packages/monorepo-scripts/src/publish_release_notes.ts
+++ b/packages/monorepo-scripts/src/publish_release_notes.ts
@@ -17,6 +17,7 @@ const args = yargs
     const allUpdatedPackages = await utils.getUpdatedPackagesAsync(shouldIncludePrivate);
 
     await publishReleaseNotesAsync(allUpdatedPackages, isDryRun);
+    process.exit(0);
 })().catch(err => {
     utils.log(err);
     process.exit(1);
diff --git a/packages/monorepo-scripts/src/test_installation.ts b/packages/monorepo-scripts/src/test_installation.ts
index 87c4ad1d7..be39b1878 100644
--- a/packages/monorepo-scripts/src/test_installation.ts
+++ b/packages/monorepo-scripts/src/test_installation.ts
@@ -85,11 +85,13 @@ function logIfDefined(x: any): void {
             logIfDefined(packageError.error.stdout);
             logIfDefined(packageError.error.stack);
         });
+        process.exit(1);
+    } else {
         process.exit(0);
     }
 })().catch(err => {
     utils.log(`Unexpected error: ${err.message}`);
-    process.exit(0);
+    process.exit(1);
 });
 
 async function testInstallPackageAsync(
@@ -144,7 +146,7 @@ async function testInstallPackageAsync(
         const transpiledIndexFilePath = path.join(testDirectory, 'index.js');
         utils.log(`Running test script with ${packageName} imported`);
         await execAsync(`node ${transpiledIndexFilePath}`);
-        utils.log(`Successfilly ran test script with ${packageName} imported`);
+        utils.log(`Successfully ran test script with ${packageName} imported`);
     }
     await rimrafAsync(testDirectory);
 }
diff --git a/packages/monorepo-scripts/src/utils/changelog_utils.ts b/packages/monorepo-scripts/src/utils/changelog_utils.ts
index 4781b3b7d..8058d222b 100644
--- a/packages/monorepo-scripts/src/utils/changelog_utils.ts
+++ b/packages/monorepo-scripts/src/utils/changelog_utils.ts
@@ -19,11 +19,6 @@ CHANGELOG
 
 export const changelogUtils = {
     getChangelogMdTitle(versionChangelog: VersionChangelog): string {
-        if (_.isUndefined(versionChangelog.timestamp)) {
-            throw new Error(
-                'All CHANGELOG.json entries must be updated to include a timestamp before generating their MD version',
-            );
-        }
         const date = moment(`${versionChangelog.timestamp}`, 'X').format('MMMM D, YYYY');
         const title = `\n## v${versionChangelog.version} - _${date}_\n\n`;
         return title;