aboutsummaryrefslogtreecommitdiffstats
path: root/packages/fill-scenarios
diff options
context:
space:
mode:
authorBrandon Millman <brandon.millman@gmail.com>2018-08-06 04:51:53 +0800
committerBrandon Millman <brandon.millman@gmail.com>2018-08-06 04:54:35 +0800
commit47673ba4bb2932051cb810bd0012c208665eb277 (patch)
treeb00a2ec6a46b99a0303db89a5046d576551569c4 /packages/fill-scenarios
parent3865a081a0f8ea48be736adebb8dcdb4b7d80b04 (diff)
downloaddexon-sol-tools-47673ba4bb2932051cb810bd0012c208665eb277.tar
dexon-sol-tools-47673ba4bb2932051cb810bd0012c208665eb277.tar.gz
dexon-sol-tools-47673ba4bb2932051cb810bd0012c208665eb277.tar.bz2
dexon-sol-tools-47673ba4bb2932051cb810bd0012c208665eb277.tar.lz
dexon-sol-tools-47673ba4bb2932051cb810bd0012c208665eb277.tar.xz
dexon-sol-tools-47673ba4bb2932051cb810bd0012c208665eb277.tar.zst
dexon-sol-tools-47673ba4bb2932051cb810bd0012c208665eb277.zip
Update createFactory to accept one createOrderOpts param to encompass all optional params
Diffstat (limited to 'packages/fill-scenarios')
-rw-r--r--packages/fill-scenarios/CHANGELOG.json3
-rw-r--r--packages/fill-scenarios/src/fill_scenarios.ts24
2 files changed, 15 insertions, 12 deletions
diff --git a/packages/fill-scenarios/CHANGELOG.json b/packages/fill-scenarios/CHANGELOG.json
index af1f79cf9..04e076203 100644
--- a/packages/fill-scenarios/CHANGELOG.json
+++ b/packages/fill-scenarios/CHANGELOG.json
@@ -3,7 +3,8 @@
"version": "1.0.1-rc.3",
"changes": [
{
- "note": "Updated to use latest orderFactory interface",
+ "note":
+ "Updated to use latest orderFactory interface, fixed `feeRecipient` spelling error in public interface",
"pr": 936
}
]
diff --git a/packages/fill-scenarios/src/fill_scenarios.ts b/packages/fill-scenarios/src/fill_scenarios.ts
index f35094560..1a1adb326 100644
--- a/packages/fill-scenarios/src/fill_scenarios.ts
+++ b/packages/fill-scenarios/src/fill_scenarios.ts
@@ -61,7 +61,7 @@ export class FillScenarios {
makerAddress: string,
takerAddress: string,
fillableAmount: BigNumber,
- feeRecepientAddress: string,
+ feeRecipientAddress: string,
expirationTimeSeconds?: BigNumber,
): Promise<SignedOrder> {
return this._createAsymmetricFillableSignedOrderWithFeesAsync(
@@ -73,7 +73,7 @@ export class FillScenarios {
takerAddress,
fillableAmount,
fillableAmount,
- feeRecepientAddress,
+ feeRecipientAddress,
expirationTimeSeconds,
);
}
@@ -88,7 +88,7 @@ export class FillScenarios {
): Promise<SignedOrder> {
const makerFee = new BigNumber(0);
const takerFee = new BigNumber(0);
- const feeRecepientAddress = constants.NULL_ADDRESS;
+ const feeRecipientAddress = constants.NULL_ADDRESS;
return this._createAsymmetricFillableSignedOrderWithFeesAsync(
makerAssetData,
takerAssetData,
@@ -98,7 +98,7 @@ export class FillScenarios {
takerAddress,
makerFillableAmount,
takerFillableAmount,
- feeRecepientAddress,
+ feeRecipientAddress,
expirationTimeSeconds,
);
}
@@ -148,7 +148,7 @@ export class FillScenarios {
takerAddress: string,
makerFillableAmount: BigNumber,
takerFillableAmount: BigNumber,
- feeRecepientAddress: string,
+ feeRecipientAddress: string,
expirationTimeSeconds?: BigNumber,
): Promise<SignedOrder> {
const decodedMakerAssetData = assetDataUtils.decodeAssetDataOrThrow(makerAssetData);
@@ -199,12 +199,14 @@ export class FillScenarios {
takerFillableAmount,
takerAssetData,
this._exchangeAddress,
- takerAddress,
- senderAddress,
- makerFee,
- takerFee,
- feeRecepientAddress,
- expirationTimeSeconds,
+ {
+ takerAddress,
+ senderAddress,
+ makerFee,
+ takerFee,
+ feeRecipientAddress,
+ expirationTimeSeconds,
+ },
);
return signedOrder;
}