diff options
| author | Alex Browne <stephenalexbrowne@gmail.com> | 2018-07-03 09:44:37 +0800 |
|---|---|---|
| committer | Alex Browne <stephenalexbrowne@gmail.com> | 2018-07-03 09:57:33 +0800 |
| commit | 5b64b3ea937326978b5742ec1b3692ebe5c41991 (patch) | |
| tree | 34f4029b1985295490479d3da93cae62de5396d1 /packages/contracts/test/exchange/signature_validator.ts | |
| parent | b1dc20bbb35e8fb6370820a94d6f56306453fc4d (diff) | |
| download | dexon-sol-tools-5b64b3ea937326978b5742ec1b3692ebe5c41991.tar dexon-sol-tools-5b64b3ea937326978b5742ec1b3692ebe5c41991.tar.gz dexon-sol-tools-5b64b3ea937326978b5742ec1b3692ebe5c41991.tar.bz2 dexon-sol-tools-5b64b3ea937326978b5742ec1b3692ebe5c41991.tar.lz dexon-sol-tools-5b64b3ea937326978b5742ec1b3692ebe5c41991.tar.xz dexon-sol-tools-5b64b3ea937326978b5742ec1b3692ebe5c41991.tar.zst dexon-sol-tools-5b64b3ea937326978b5742ec1b3692ebe5c41991.zip | |
Improve robustness of revert reason assertions
Diffstat (limited to 'packages/contracts/test/exchange/signature_validator.ts')
| -rw-r--r-- | packages/contracts/test/exchange/signature_validator.ts | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/packages/contracts/test/exchange/signature_validator.ts b/packages/contracts/test/exchange/signature_validator.ts index 1db7dfc6d..c44d22479 100644 --- a/packages/contracts/test/exchange/signature_validator.ts +++ b/packages/contracts/test/exchange/signature_validator.ts @@ -13,7 +13,7 @@ import { TestValidatorContract } from '../../generated_contract_wrappers/test_va import { TestWalletContract } from '../../generated_contract_wrappers/test_wallet'; import { addressUtils } from '../utils/address_utils'; import { artifacts } from '../utils/artifacts'; -import { expectRevertOrOtherErrorAsync } from '../utils/assertions'; +import { expectContractCallFailed } from '../utils/assertions'; import { chaiSetup } from '../utils/chai_setup'; import { constants } from '../utils/constants'; import { LogDecoder } from '../utils/log_decoder'; @@ -101,7 +101,7 @@ describe('MixinSignatureValidator', () => { it('should revert when signature is empty', async () => { const emptySignature = '0x'; const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder); - return expectRevertOrOtherErrorAsync( + return expectContractCallFailed( signatureValidator.publicIsValidSignature.callAsync( orderHashHex, signedOrder.makerAddress, @@ -115,7 +115,7 @@ describe('MixinSignatureValidator', () => { const unsupportedSignatureType = SignatureType.NSignatureTypes; const unsupportedSignatureHex = `0x${unsupportedSignatureType}`; const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder); - return expectRevertOrOtherErrorAsync( + return expectContractCallFailed( signatureValidator.publicIsValidSignature.callAsync( orderHashHex, signedOrder.makerAddress, @@ -128,7 +128,7 @@ describe('MixinSignatureValidator', () => { it('should revert when SignatureType=Illegal', async () => { const unsupportedSignatureHex = `0x${SignatureType.Illegal}`; const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder); - return expectRevertOrOtherErrorAsync( + return expectContractCallFailed( signatureValidator.publicIsValidSignature.callAsync( orderHashHex, signedOrder.makerAddress, @@ -155,7 +155,7 @@ describe('MixinSignatureValidator', () => { const signatureBuffer = Buffer.concat([fillerData, signatureType]); const signatureHex = ethUtil.bufferToHex(signatureBuffer); const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder); - return expectRevertOrOtherErrorAsync( + return expectContractCallFailed( signatureValidator.publicIsValidSignature.callAsync( orderHashHex, signedOrder.makerAddress, |