aboutsummaryrefslogtreecommitdiffstats
path: root/packages/contracts/src/2.0.0
diff options
context:
space:
mode:
authorAmir Bandeali <abandeali1@gmail.com>2018-08-09 04:58:29 +0800
committerAmir Bandeali <abandeali1@gmail.com>2018-08-09 04:58:29 +0800
commit68fb1bf37622e244f7dbce276a7c3355e4ec88eb (patch)
treee69966e46ba3f11258429d296426b3ffbae6d1e2 /packages/contracts/src/2.0.0
parenta6ccfaf9caf20cbc4969c0673cf0c83c33553e0a (diff)
downloaddexon-sol-tools-68fb1bf37622e244f7dbce276a7c3355e4ec88eb.tar
dexon-sol-tools-68fb1bf37622e244f7dbce276a7c3355e4ec88eb.tar.gz
dexon-sol-tools-68fb1bf37622e244f7dbce276a7c3355e4ec88eb.tar.bz2
dexon-sol-tools-68fb1bf37622e244f7dbce276a7c3355e4ec88eb.tar.lz
dexon-sol-tools-68fb1bf37622e244f7dbce276a7c3355e4ec88eb.tar.xz
dexon-sol-tools-68fb1bf37622e244f7dbce276a7c3355e4ec88eb.tar.zst
dexon-sol-tools-68fb1bf37622e244f7dbce276a7c3355e4ec88eb.zip
fix comments and styling for MixinSignatureValidator
Diffstat (limited to 'packages/contracts/src/2.0.0')
-rw-r--r--packages/contracts/src/2.0.0/protocol/Exchange/MixinSignatureValidator.sol13
1 files changed, 9 insertions, 4 deletions
diff --git a/packages/contracts/src/2.0.0/protocol/Exchange/MixinSignatureValidator.sol b/packages/contracts/src/2.0.0/protocol/Exchange/MixinSignatureValidator.sol
index ac7382715..44de54817 100644
--- a/packages/contracts/src/2.0.0/protocol/Exchange/MixinSignatureValidator.sol
+++ b/packages/contracts/src/2.0.0/protocol/Exchange/MixinSignatureValidator.sol
@@ -96,14 +96,15 @@ contract MixinSignatureValidator is
"LENGTH_GREATER_THAN_0_REQUIRED"
);
- // Ensure signature is supported
+ // Pop last byte off of signature byte array.
uint8 signatureTypeRaw = uint8(signature.popLastByte());
+
+ // Ensure signature is supported
require(
signatureTypeRaw < uint8(SignatureType.NSignatureTypes),
"SIGNATURE_UNSUPPORTED"
);
- // Pop last byte off of signature byte array.
SignatureType signatureType = SignatureType(signatureTypeRaw);
// Variables are not scoped in Solidity.
@@ -141,7 +142,12 @@ contract MixinSignatureValidator is
v = uint8(signature[0]);
r = signature.readBytes32(1);
s = signature.readBytes32(33);
- recovered = ecrecover(hash, v, r, s);
+ recovered = ecrecover(
+ hash,
+ v,
+ r,
+ s
+ );
isValid = signerAddress == recovered;
return isValid;
@@ -197,7 +203,6 @@ contract MixinSignatureValidator is
// | 0x14 + x | 1 | Signature type is always "\x06" |
} else if (signatureType == SignatureType.Validator) {
// Pop last 20 bytes off of signature byte array.
-
address validatorAddress = signature.popLast20Bytes();
// Ensure signer has approved validator.