aboutsummaryrefslogtreecommitdiffstats
path: root/packages/contract-wrappers
diff options
context:
space:
mode:
authorBrandon Millman <brandon.millman@gmail.com>2018-08-30 12:36:20 +0800
committerBrandon Millman <brandon.millman@gmail.com>2018-08-31 04:24:24 +0800
commit01685b7622f7c29137aba65f1836a344b1321555 (patch)
treeff6888d43ea7f6dad9e1d4221d332240e81740c2 /packages/contract-wrappers
parent397fefa8d7bc2761ee8b7be786e710f86cc30fec (diff)
downloaddexon-sol-tools-01685b7622f7c29137aba65f1836a344b1321555.tar
dexon-sol-tools-01685b7622f7c29137aba65f1836a344b1321555.tar.gz
dexon-sol-tools-01685b7622f7c29137aba65f1836a344b1321555.tar.bz2
dexon-sol-tools-01685b7622f7c29137aba65f1836a344b1321555.tar.lz
dexon-sol-tools-01685b7622f7c29137aba65f1836a344b1321555.tar.xz
dexon-sol-tools-01685b7622f7c29137aba65f1836a344b1321555.tar.zst
dexon-sol-tools-01685b7622f7c29137aba65f1836a344b1321555.zip
Fix contract not deployed on network bug in ContractWrapper class
Diffstat (limited to 'packages/contract-wrappers')
-rw-r--r--packages/contract-wrappers/CHANGELOG.json4
-rw-r--r--packages/contract-wrappers/src/contract_wrappers/contract_wrapper.ts5
2 files changed, 8 insertions, 1 deletions
diff --git a/packages/contract-wrappers/CHANGELOG.json b/packages/contract-wrappers/CHANGELOG.json
index b7c89a325..3bd89862a 100644
--- a/packages/contract-wrappers/CHANGELOG.json
+++ b/packages/contract-wrappers/CHANGELOG.json
@@ -4,6 +4,10 @@
"changes": [
{
"note": "Add `OrderValidatorWrapper`"
+ },
+ {
+ "note":
+ "Fix bug where contracts not deployed on a network showed an `EXCHANGE_CONTRACT_DOES_NOT_EXIST` error instead of `CONTRACT_NOT_DEPLOYED_ON_NETWORK`"
}
]
},
diff --git a/packages/contract-wrappers/src/contract_wrappers/contract_wrapper.ts b/packages/contract-wrappers/src/contract_wrappers/contract_wrapper.ts
index ba36afea1..19de17c0a 100644
--- a/packages/contract-wrappers/src/contract_wrappers/contract_wrapper.ts
+++ b/packages/contract-wrappers/src/contract_wrappers/contract_wrapper.ts
@@ -145,9 +145,12 @@ export abstract class ContractWrapper {
}
protected _getContractAddress(artifact: ContractArtifact, addressIfExists?: string): string {
if (_.isUndefined(addressIfExists)) {
+ if (_.isUndefined(artifact.networks[this._networkId])) {
+ throw new Error(ContractWrappersError.ContractNotDeployedOnNetwork);
+ }
const contractAddress = artifact.networks[this._networkId].address;
if (_.isUndefined(contractAddress)) {
- throw new Error(ContractWrappersError.ExchangeContractDoesNotExist);
+ throw new Error(CONTRACT_NAME_TO_NOT_FOUND_ERROR[artifact.contractName]);
}
return contractAddress;
} else {