diff options
| author | Leonid Logvinov <logvinov.leon@gmail.com> | 2018-07-03 21:25:13 +0800 |
|---|---|---|
| committer | Leonid Logvinov <logvinov.leon@gmail.com> | 2018-07-05 21:58:41 +0800 |
| commit | b68d16820fbc2cab529a95a0dfabc645a9e2de34 (patch) | |
| tree | f5626efddea97ef8e94f5e1650c425d409e1ec08 /packages/contract-wrappers/src/contract_wrappers | |
| parent | 61d9cdced09752828095cdd1e54c6c14da2cc031 (diff) | |
| download | dexon-sol-tools-b68d16820fbc2cab529a95a0dfabc645a9e2de34.tar dexon-sol-tools-b68d16820fbc2cab529a95a0dfabc645a9e2de34.tar.gz dexon-sol-tools-b68d16820fbc2cab529a95a0dfabc645a9e2de34.tar.bz2 dexon-sol-tools-b68d16820fbc2cab529a95a0dfabc645a9e2de34.tar.lz dexon-sol-tools-b68d16820fbc2cab529a95a0dfabc645a9e2de34.tar.xz dexon-sol-tools-b68d16820fbc2cab529a95a0dfabc645a9e2de34.tar.zst dexon-sol-tools-b68d16820fbc2cab529a95a0dfabc645a9e2de34.zip | |
Fix match orders test and add a validation TODO
Diffstat (limited to 'packages/contract-wrappers/src/contract_wrappers')
| -rw-r--r-- | packages/contract-wrappers/src/contract_wrappers/exchange_wrapper.ts | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/packages/contract-wrappers/src/contract_wrappers/exchange_wrapper.ts b/packages/contract-wrappers/src/contract_wrappers/exchange_wrapper.ts index d381db1a4..0377c4021 100644 --- a/packages/contract-wrappers/src/contract_wrappers/exchange_wrapper.ts +++ b/packages/contract-wrappers/src/contract_wrappers/exchange_wrapper.ts @@ -625,7 +625,9 @@ export class ExchangeWrapper extends ContractWrapper { await assert.isSenderAddressAsync('takerAddress', takerAddress, this._web3Wrapper); assert.doesConformToSchema('orderTransactionOpts', orderTransactionOpts, orderTxOptsSchema, [txOptsSchema]); const normalizedTakerAddress = takerAddress.toLowerCase(); - + // TODO(logvinov): Check that: + // rightOrder.makerAssetData === leftOrder.takerAssetData; + // rightOrder.takerAssetData === leftOrder.makerAssetData; const exchangeInstance = await this._getExchangeContractAsync(); const txHash = await exchangeInstance.matchOrders.sendTransactionAsync( leftSignedOrder, |