aboutsummaryrefslogtreecommitdiffstats
path: root/packages/connect/src
diff options
context:
space:
mode:
authorBrandon Millman <brandon@0xproject.com>2018-01-09 08:57:59 +0800
committerGitHub <noreply@github.com>2018-01-09 08:57:59 +0800
commit7a56e83fa3ca02d796deba3359da480834a9f6ea (patch)
tree41cf689624c493d47f669421f63392cb36107915 /packages/connect/src
parent35e0b6143ab1405259471e1c9c698bfcd869df5a (diff)
parenta1c38d9cb2da75915248c7bad0d0e13523db389c (diff)
downloaddexon-sol-tools-7a56e83fa3ca02d796deba3359da480834a9f6ea.tar
dexon-sol-tools-7a56e83fa3ca02d796deba3359da480834a9f6ea.tar.gz
dexon-sol-tools-7a56e83fa3ca02d796deba3359da480834a9f6ea.tar.bz2
dexon-sol-tools-7a56e83fa3ca02d796deba3359da480834a9f6ea.tar.lz
dexon-sol-tools-7a56e83fa3ca02d796deba3359da480834a9f6ea.tar.xz
dexon-sol-tools-7a56e83fa3ca02d796deba3359da480834a9f6ea.tar.zst
dexon-sol-tools-7a56e83fa3ca02d796deba3359da480834a9f6ea.zip
Merge pull request #296 from 0xProject/fix/mutatedInput
Prevent getFeesAsync method on HttpClient from mutating input
Diffstat (limited to 'packages/connect/src')
-rw-r--r--packages/connect/src/http_client.ts6
-rw-r--r--packages/connect/src/utils/type_converters.ts5
2 files changed, 0 insertions, 11 deletions
diff --git a/packages/connect/src/http_client.ts b/packages/connect/src/http_client.ts
index 06b5d8ace..dcaf5d9a9 100644
--- a/packages/connect/src/http_client.ts
+++ b/packages/connect/src/http_client.ts
@@ -111,12 +111,6 @@ export class HttpClient implements Client {
*/
public async getFeesAsync(request: FeesRequest): Promise<FeesResponse> {
assert.doesConformToSchema('request', request, schemas.relayerApiFeesPayloadSchema);
- typeConverters.convertBigNumberFieldsToStrings(request, [
- 'makerTokenAmount',
- 'takerTokenAmount',
- 'expirationUnixTimestampSec',
- 'salt',
- ]);
const requestOpts = {
payload: request,
};
diff --git a/packages/connect/src/utils/type_converters.ts b/packages/connect/src/utils/type_converters.ts
index 31abdc95c..ccbc40677 100644
--- a/packages/connect/src/utils/type_converters.ts
+++ b/packages/connect/src/utils/type_converters.ts
@@ -18,11 +18,6 @@ export const typeConverters = {
'salt',
]);
},
- convertBigNumberFieldsToStrings(obj: object, fields: string[]): void {
- _.each(fields, field => {
- _.update(obj, field, (value: BigNumber) => value.toString());
- });
- },
convertStringsFieldsToBigNumbers(obj: object, fields: string[]): void {
_.each(fields, field => {
_.update(obj, field, (value: string) => new BigNumber(value));