Merge pull request #296 from 0xProject/fix/mutatedInput

Prevent getFeesAsync method on HttpClient from mutating input

2 files changed, 0 insertions, 11 deletions

diff --git a/packages/connect/src/http_client.ts b/packages/connect/src/http_client.ts
index 06b5d8ace..dcaf5d9a9 100644
--- a/packages/connect/src/http_client.ts
+++ b/packages/connect/src/http_client.ts
@@ -111,12 +111,6 @@ export class HttpClient implements Client {
      */
     public async getFeesAsync(request: FeesRequest): Promise<FeesResponse> {
         assert.doesConformToSchema('request', request, schemas.relayerApiFeesPayloadSchema);
-        typeConverters.convertBigNumberFieldsToStrings(request, [
-            'makerTokenAmount',
-            'takerTokenAmount',
-            'expirationUnixTimestampSec',
-            'salt',
-        ]);
         const requestOpts = {
             payload: request,
         };
diff --git a/packages/connect/src/utils/type_converters.ts b/packages/connect/src/utils/type_converters.ts
index 31abdc95c..ccbc40677 100644
--- a/packages/connect/src/utils/type_converters.ts
+++ b/packages/connect/src/utils/type_converters.ts
@@ -18,11 +18,6 @@ export const typeConverters = {
             'salt',
         ]);
     },
-    convertBigNumberFieldsToStrings(obj: object, fields: string[]): void {
-        _.each(fields, field => {
-            _.update(obj, field, (value: BigNumber) => value.toString());
-        });
-    },
     convertStringsFieldsToBigNumbers(obj: object, fields: string[]): void {
         _.each(fields, field => {
             _.update(obj, field, (value: string) => new BigNumber(value));