aboutsummaryrefslogtreecommitdiffstats
path: root/packages/asset-buyer
diff options
context:
space:
mode:
authorLeonid Logvinov <logvinov.leon@gmail.com>2019-01-14 19:17:12 +0800
committerLeonid Logvinov <logvinov.leon@gmail.com>2019-01-14 19:17:12 +0800
commitbf183af9a42aefd1c639e5924ed93f93fd821378 (patch)
treefd2f875248d8ccd4f287c61e749787343cec5723 /packages/asset-buyer
parent2b8f0d887ad529bb0557a55c67cc162977c7b270 (diff)
parent797d7c7878e33ce012259a6a5db5335e9dc838ba (diff)
downloaddexon-sol-tools-bf183af9a42aefd1c639e5924ed93f93fd821378.tar
dexon-sol-tools-bf183af9a42aefd1c639e5924ed93f93fd821378.tar.gz
dexon-sol-tools-bf183af9a42aefd1c639e5924ed93f93fd821378.tar.bz2
dexon-sol-tools-bf183af9a42aefd1c639e5924ed93f93fd821378.tar.lz
dexon-sol-tools-bf183af9a42aefd1c639e5924ed93f93fd821378.tar.xz
dexon-sol-tools-bf183af9a42aefd1c639e5924ed93f93fd821378.tar.zst
dexon-sol-tools-bf183af9a42aefd1c639e5924ed93f93fd821378.zip
Merge development
Diffstat (limited to 'packages/asset-buyer')
-rw-r--r--packages/asset-buyer/CHANGELOG.json15
-rw-r--r--packages/asset-buyer/CHANGELOG.md4
-rw-r--r--packages/asset-buyer/package.json26
-rw-r--r--packages/asset-buyer/src/utils/order_provider_response_processor.ts2
4 files changed, 24 insertions, 23 deletions
diff --git a/packages/asset-buyer/CHANGELOG.json b/packages/asset-buyer/CHANGELOG.json
index a7f8d3418..1548a43f7 100644
--- a/packages/asset-buyer/CHANGELOG.json
+++ b/packages/asset-buyer/CHANGELOG.json
@@ -6,7 +6,8 @@
"note": "Raise custom InsufficientAssetLiquidityError error with amountAvailableToFill attribute",
"pr": 1437
}
- ]
+ ],
+ "timestamp": 1547225310
},
{
"timestamp": 1547040760,
@@ -90,8 +91,7 @@
"pr": 1187
},
{
- "note":
- "the `OrderProvider` now requires a new method `getAvailableMakerAssetDatasAsync` and the `StandardRelayerAPIOrderProvider` requires the network id at init.",
+ "note": "the `OrderProvider` now requires a new method `getAvailableMakerAssetDatasAsync` and the `StandardRelayerAPIOrderProvider` requires the network id at init.",
"pr": 1203
},
{
@@ -99,13 +99,11 @@
"pr": 1197
},
{
- "note":
- "Fix bug where `BuyQuoteInfo` objects could return `totalEthAmount` and `feeEthAmount` that were not whole numbers",
+ "note": "Fix bug where `BuyQuoteInfo` objects could return `totalEthAmount` and `feeEthAmount` that were not whole numbers",
"pr": 1207
},
{
- "note":
- "Fix bug where default values for `AssetBuyer` public facing methods could get overriden by `undefined` values",
+ "note": "Fix bug where default values for `AssetBuyer` public facing methods could get overriden by `undefined` values",
"pr": 1207
},
{
@@ -126,8 +124,7 @@
"pr": 1131
},
{
- "note":
- "Updated to use new modularized artifacts and the latest version of @0xproject/contract-wrappers",
+ "note": "Updated to use new modularized artifacts and the latest version of @0xproject/contract-wrappers",
"pr": 1105
},
{
diff --git a/packages/asset-buyer/CHANGELOG.md b/packages/asset-buyer/CHANGELOG.md
index 70bbe8302..13d52571b 100644
--- a/packages/asset-buyer/CHANGELOG.md
+++ b/packages/asset-buyer/CHANGELOG.md
@@ -5,6 +5,10 @@ Edit the package's CHANGELOG.json file only.
CHANGELOG
+## v4.0.0 - _January 11, 2019_
+
+ * Raise custom InsufficientAssetLiquidityError error with amountAvailableToFill attribute (#1437)
+
## v3.0.5 - _January 9, 2019_
* Dependencies updated
diff --git a/packages/asset-buyer/package.json b/packages/asset-buyer/package.json
index dd6780e48..3e1c26814 100644
--- a/packages/asset-buyer/package.json
+++ b/packages/asset-buyer/package.json
@@ -1,6 +1,6 @@
{
"name": "@0x/asset-buyer",
- "version": "3.0.5",
+ "version": "4.0.0",
"engines": {
"node": ">=6.12"
},
@@ -36,21 +36,21 @@
},
"homepage": "https://github.com/0xProject/0x-monorepo/packages/asset-buyer/README.md",
"dependencies": {
- "@0x/assert": "^1.0.21",
- "@0x/connect": "^3.0.11",
- "@0x/contract-wrappers": "^4.2.0",
- "@0x/json-schemas": "^2.1.5",
- "@0x/order-utils": "^3.1.0",
- "@0x/subproviders": "^2.1.9",
- "@0x/types": "^1.5.0",
- "@0x/typescript-typings": "^3.0.6",
- "@0x/utils": "^2.1.1",
- "@0x/web3-wrapper": "^3.2.2",
- "ethereum-types": "^1.1.4",
+ "@0x/assert": "^1.0.22",
+ "@0x/connect": "^3.0.12",
+ "@0x/contract-wrappers": "^4.2.1",
+ "@0x/json-schemas": "^2.1.6",
+ "@0x/order-utils": "^3.1.1",
+ "@0x/subproviders": "^2.1.10",
+ "@0x/types": "^1.5.1",
+ "@0x/typescript-typings": "^3.0.7",
+ "@0x/utils": "^3.0.0",
+ "@0x/web3-wrapper": "^3.2.3",
+ "ethereum-types": "^1.1.5",
"lodash": "^4.17.5"
},
"devDependencies": {
- "@0x/tslint-config": "^2.0.0",
+ "@0x/tslint-config": "^2.0.1",
"@types/lodash": "^4.14.116",
"@types/mocha": "^2.2.42",
"@types/node": "*",
diff --git a/packages/asset-buyer/src/utils/order_provider_response_processor.ts b/packages/asset-buyer/src/utils/order_provider_response_processor.ts
index 25e85b2cc..4244d196c 100644
--- a/packages/asset-buyer/src/utils/order_provider_response_processor.ts
+++ b/packages/asset-buyer/src/utils/order_provider_response_processor.ts
@@ -105,7 +105,7 @@ function getValidOrdersWithRemainingFillableMakerAssetAmountsFromOnChain(
// get corresponding on-chain state for the order
const { orderInfo, traderInfo } = ordersAndTradersInfo[index];
// if the order IS NOT fillable, do not add anything to the accumulations and continue iterating
- if (orderInfo.orderStatus !== OrderStatus.FILLABLE) {
+ if (orderInfo.orderStatus !== OrderStatus.Fillable) {
return accOrders;
}
// if the order IS fillable, add the order and calculate the remaining fillable amount