aboutsummaryrefslogtreecommitdiffstats
path: root/packages/asset-buyer/src/utils
diff options
context:
space:
mode:
authorfragosti <francesco.agosti93@gmail.com>2018-09-21 20:56:54 +0800
committerfragosti <francesco.agosti93@gmail.com>2018-09-21 20:56:54 +0800
commit97150cf55f472ca5c77b28d064976d84df9f2436 (patch)
tree77f25dcad220461b146ec99d1ec8a909a8e972b6 /packages/asset-buyer/src/utils
parentfcca63a2dc17f7745304d02dfaffe60f0d6785c4 (diff)
downloaddexon-sol-tools-97150cf55f472ca5c77b28d064976d84df9f2436.tar
dexon-sol-tools-97150cf55f472ca5c77b28d064976d84df9f2436.tar.gz
dexon-sol-tools-97150cf55f472ca5c77b28d064976d84df9f2436.tar.bz2
dexon-sol-tools-97150cf55f472ca5c77b28d064976d84df9f2436.tar.lz
dexon-sol-tools-97150cf55f472ca5c77b28d064976d84df9f2436.tar.xz
dexon-sol-tools-97150cf55f472ca5c77b28d064976d84df9f2436.tar.zst
dexon-sol-tools-97150cf55f472ca5c77b28d064976d84df9f2436.zip
Add labels to TODOs
Diffstat (limited to 'packages/asset-buyer/src/utils')
-rw-r--r--packages/asset-buyer/src/utils/buy_quote_calculator.ts3
-rw-r--r--packages/asset-buyer/src/utils/order_fetcher_response_processor.ts6
2 files changed, 5 insertions, 4 deletions
diff --git a/packages/asset-buyer/src/utils/buy_quote_calculator.ts b/packages/asset-buyer/src/utils/buy_quote_calculator.ts
index aa7159e6c..3d90a6ead 100644
--- a/packages/asset-buyer/src/utils/buy_quote_calculator.ts
+++ b/packages/asset-buyer/src/utils/buy_quote_calculator.ts
@@ -3,9 +3,10 @@ import { BigNumber } from '@0xproject/utils';
import * as _ from 'lodash';
import { constants } from '../constants';
-import { orderUtils } from './order_utils';
import { AssetBuyerError, AssetBuyerOrdersAndFillableAmounts, BuyQuote } from '../types';
+import { orderUtils } from './order_utils';
+
export const buyQuoteCalculator = {
calculate(
ordersAndFillableAmounts: AssetBuyerOrdersAndFillableAmounts,
diff --git a/packages/asset-buyer/src/utils/order_fetcher_response_processor.ts b/packages/asset-buyer/src/utils/order_fetcher_response_processor.ts
index 98ab6b9d1..ec4a6ce7e 100644
--- a/packages/asset-buyer/src/utils/order_fetcher_response_processor.ts
+++ b/packages/asset-buyer/src/utils/order_fetcher_response_processor.ts
@@ -41,9 +41,9 @@ export const orderFetcherResponseProcessor = {
let unsortedFeeOrders = filteredFeeOrders;
// if an orderValidator is provided, use on chain information to calculate remaining fillable makerAsset amounts
if (!_.isUndefined(orderValidator)) {
- // TODO: critical
+ // TODO(bmillman): improvement
// try catch these requests and throw a more domain specific error
- // TODO: optimization
+ // TODO(bmillman): optimization
// reduce this to once RPC call buy combining orders into one array and then splitting up the response
const [targetOrdersAndTradersInfo, feeOrdersAndTradersInfo] = await Promise.all(
_.map([filteredTargetOrders, filteredFeeOrders], ordersToBeValidated => {
@@ -65,7 +65,7 @@ export const orderFetcherResponseProcessor = {
);
}
// sort orders by rate
- // TODO: optimization
+ // TODO(bmillman): optimization
// provide a feeRate to the sorting function to more accurately sort based on the current market for ZRX tokens
const sortedTargetOrders = sortingUtils.sortOrdersByFeeAdjustedRate(unsortedTargetOrders);
const sortedFeeOrders = sortingUtils.sortFeeOrdersByFeeAdjustedRate(unsortedFeeOrders);