diff options
| author | Fabio Berger <me@fabioberger.com> | 2018-07-05 21:04:58 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-07-05 21:04:58 +0800 |
| commit | 87a7a4ad2d55641cbe06d7157df0d8f0996d033a (patch) | |
| tree | f0374adf1f3e6d87df25032499f14ec7c231265c /packages/assert | |
| parent | 5176d929fa6d3c6ce414448ea2441bd450f04e3c (diff) | |
| parent | a1fb438a8c8722d14c7a1e52e844898ff5451e66 (diff) | |
| download | dexon-sol-tools-87a7a4ad2d55641cbe06d7157df0d8f0996d033a.tar dexon-sol-tools-87a7a4ad2d55641cbe06d7157df0d8f0996d033a.tar.gz dexon-sol-tools-87a7a4ad2d55641cbe06d7157df0d8f0996d033a.tar.bz2 dexon-sol-tools-87a7a4ad2d55641cbe06d7157df0d8f0996d033a.tar.lz dexon-sol-tools-87a7a4ad2d55641cbe06d7157df0d8f0996d033a.tar.xz dexon-sol-tools-87a7a4ad2d55641cbe06d7157df0d8f0996d033a.tar.zst dexon-sol-tools-87a7a4ad2d55641cbe06d7157df0d8f0996d033a.zip | |
Merge pull request #821 from 0xProject/remove-web3-from-wrapper
Remove Web3.js From 0x-monorepo 🍾
Diffstat (limited to 'packages/assert')
| -rw-r--r-- | packages/assert/CHANGELOG.json | 10 | ||||
| -rw-r--r-- | packages/assert/src/index.ts | 4 |
2 files changed, 12 insertions, 2 deletions
diff --git a/packages/assert/CHANGELOG.json b/packages/assert/CHANGELOG.json index 883d55f5b..b44cac4a1 100644 --- a/packages/assert/CHANGELOG.json +++ b/packages/assert/CHANGELOG.json @@ -1,5 +1,15 @@ [ { + "version": "0.2.13", + "changes": [ + { + "note": + "Fix bug in string enum assertion. We erroneously were checking against the enum keys, not values", + "pr": 821 + } + ] + }, + { "timestamp": 1529397769, "version": "0.2.12", "changes": [ diff --git a/packages/assert/src/index.ts b/packages/assert/src/index.ts index 95c7b658b..8e18416c5 100644 --- a/packages/assert/src/index.ts +++ b/packages/assert/src/index.ts @@ -41,8 +41,8 @@ export const assert = { value: string, stringEnum: any /* There is no base type for every string enum */, ): void { - const doesBelongToStringEnum = !_.isUndefined(stringEnum[value]); - const enumValues = _.keys(stringEnum); + const enumValues = _.values(stringEnum); + const doesBelongToStringEnum = _.includes(enumValues, value); const enumValuesAsStrings = _.map(enumValues, enumValue => `'${enumValue}'`); const enumValuesAsString = enumValuesAsStrings.join(', '); assert.assert( |