diff options
| author | Alex Browne <stephenalexbrowne@gmail.com> | 2018-08-09 09:28:15 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-08-09 09:28:15 +0800 |
| commit | 53713188fee57391040c24cc627fdc5ab8982d2e (patch) | |
| tree | 8bfcf59197506af235f772cb8fc78f6315932c4f /packages/0x.js | |
| parent | 03fb73d1d2017b41551f47552a5ca06f0dfb0f08 (diff) | |
| parent | c4c37cafa0d8a77bfdc01b1cc111ba0101e86c8b (diff) | |
| download | dexon-sol-tools-53713188fee57391040c24cc627fdc5ab8982d2e.tar dexon-sol-tools-53713188fee57391040c24cc627fdc5ab8982d2e.tar.gz dexon-sol-tools-53713188fee57391040c24cc627fdc5ab8982d2e.tar.bz2 dexon-sol-tools-53713188fee57391040c24cc627fdc5ab8982d2e.tar.lz dexon-sol-tools-53713188fee57391040c24cc627fdc5ab8982d2e.tar.xz dexon-sol-tools-53713188fee57391040c24cc627fdc5ab8982d2e.tar.zst dexon-sol-tools-53713188fee57391040c24cc627fdc5ab8982d2e.zip | |
Merge pull request #915 from 0xProject/feature/encode-decode-checks
Add strictArgumentEncodingCheck to BaseContract and use it in contract templates
Diffstat (limited to 'packages/0x.js')
| -rw-r--r-- | packages/0x.js/CHANGELOG.json | 8 | ||||
| -rw-r--r-- | packages/0x.js/test/0x.js_test.ts | 7 |
2 files changed, 12 insertions, 3 deletions
diff --git a/packages/0x.js/CHANGELOG.json b/packages/0x.js/CHANGELOG.json index 4f39a9b8c..913b7a76e 100644 --- a/packages/0x.js/CHANGELOG.json +++ b/packages/0x.js/CHANGELOG.json @@ -1,5 +1,13 @@ [ { + "version": "1.0.1-rc.3", + "changes": [ + { + "note": "Dependencies updated" + } + ] + }, + { "version": "1.0.1-rc.2", "changes": [ { diff --git a/packages/0x.js/test/0x.js_test.ts b/packages/0x.js/test/0x.js_test.ts index b4baecb1e..be2a94482 100644 --- a/packages/0x.js/test/0x.js_test.ts +++ b/packages/0x.js/test/0x.js_test.ts @@ -48,10 +48,11 @@ describe('ZeroEx library', () => { const ethSignSignature = '0x1B61a3ed31b43c8780e905a260a35faefcc527be7516aa11c0256729b5b351bc3340349190569279751135161d22529dc25add4f6069af05be04cacbda2ace225403'; const address = '0x5409ed021d9299bf6814279a6a1411a7e866a631'; + const bytes32Zeros = '0x0000000000000000000000000000000000000000000000000000000000000000'; it("should return false if the data doesn't pertain to the signature & address", async () => { - return expect((zeroEx.exchange as any).isValidSignatureAsync('0x0', address, ethSignSignature)).to.become( - false, - ); + return expect( + (zeroEx.exchange as any).isValidSignatureAsync(bytes32Zeros, address, ethSignSignature), + ).to.become(false); }); it("should return false if the address doesn't pertain to the signature & data", async () => { const validUnrelatedAddress = '0x8b0292b11a196601ed2ce54b665cafeca0347d42'; |