aboutsummaryrefslogtreecommitdiffstats
path: root/packages/0x.js/src
diff options
context:
space:
mode:
authorJacob Evans <jacob@dekz.net>2018-08-09 10:24:52 +0800
committerJacob Evans <jacob@dekz.net>2018-08-11 16:27:21 +0800
commitca4905c3436931684d113ec66882836a4d0b265b (patch)
tree75edee08dcef867185a0fec7f590f3f79a601ba2 /packages/0x.js/src
parent5d4dd406f2946b43377049d7422c72b433bc64ab (diff)
downloaddexon-sol-tools-ca4905c3436931684d113ec66882836a4d0b265b.tar
dexon-sol-tools-ca4905c3436931684d113ec66882836a4d0b265b.tar.gz
dexon-sol-tools-ca4905c3436931684d113ec66882836a4d0b265b.tar.bz2
dexon-sol-tools-ca4905c3436931684d113ec66882836a4d0b265b.tar.lz
dexon-sol-tools-ca4905c3436931684d113ec66882836a4d0b265b.tar.xz
dexon-sol-tools-ca4905c3436931684d113ec66882836a4d0b265b.tar.zst
dexon-sol-tools-ca4905c3436931684d113ec66882836a4d0b265b.zip
Rename from SignerProviderType.EthSign to SignerType.Default
Diffstat (limited to 'packages/0x.js/src')
-rw-r--r--packages/0x.js/src/0x.ts17
-rw-r--r--packages/0x.js/src/index.ts2
2 files changed, 7 insertions, 12 deletions
diff --git a/packages/0x.js/src/0x.ts b/packages/0x.js/src/0x.ts
index 86859c368..80d784552 100644
--- a/packages/0x.js/src/0x.ts
+++ b/packages/0x.js/src/0x.ts
@@ -19,14 +19,7 @@ import {
// HACK: Since we export assetDataUtils from ZeroEx and it has AssetProxyId, ERC20AssetData and ERC721AssetData
// in it's public interface, we need to import these types here.
// tslint:disable-next-line:no-unused-variable
-import {
- AssetProxyId,
- ERC20AssetData,
- ERC721AssetData,
- Order,
- SignedOrder,
- SignerProviderType,
-} from '@0xproject/types';
+import { AssetProxyId, ERC20AssetData, ERC721AssetData, Order, SignedOrder, SignerType } from '@0xproject/types';
import { BigNumber } from '@0xproject/utils';
import { Web3Wrapper } from '@0xproject/web3-wrapper';
import { Provider, TransactionReceiptWithDecodedLogs } from 'ethereum-types';
@@ -244,19 +237,21 @@ export class ZeroEx {
* @param orderHash Hex encoded orderHash to sign.
* @param signerAddress The hex encoded Ethereum address you wish to sign it with. This address
* must be available via the Provider supplied to 0x.js.
- * @param SignerProviderType The type of Signer Provider which implements `eth_sign`. E.g Metamask, Ledger, Trezor or EthSign.
+ * @param signerType the type signer that will perform the `eth_sign` operation. E.g Default, Metamask, Ledger or Trezor.
+ * Some implementations exhibit different behaviour. Default will assume a spec compliant eth_sign implementation.
+ * This parameter is defaulted to `SignerType.Default`.
* @return A hex encoded string of the Elliptic curve signature parameters generated by signing the orderHash and signature type.
*/
public async ecSignOrderHashAsync(
orderHash: string,
signerAddress: string,
- signerProviderType: SignerProviderType,
+ signerType: SignerType = SignerType.Default,
): Promise<string> {
const signature = await ecSignOrderHashAsync(
this._contractWrappers.getProvider(),
orderHash,
signerAddress,
- signerProviderType,
+ signerType,
);
return signature;
}
diff --git a/packages/0x.js/src/index.ts b/packages/0x.js/src/index.ts
index 1e5c0c270..2ba60e730 100644
--- a/packages/0x.js/src/index.ts
+++ b/packages/0x.js/src/index.ts
@@ -6,7 +6,7 @@ export {
ExchangeContractErrs,
Order,
SignedOrder,
- SignerProviderType,
+ SignerType,
ECSignature,
OrderStateValid,
OrderStateInvalid,