diff options
author | Fabio Berger <me@fabioberger.com> | 2018-06-20 19:25:29 +0800 |
---|---|---|
committer | Fabio Berger <me@fabioberger.com> | 2018-06-20 19:25:29 +0800 |
commit | 2ffab2218584fac5d3ea2b264a7c746d963083d9 (patch) | |
tree | f7558147b811c06300e2c7697591466ae7cf48ba /PULL_REQUEST_TEMPLATE.md | |
parent | 5541327968ad6f974a37c49057253746f738a709 (diff) | |
parent | 096eaa20d785baee07b06b3f0848797e470fbda0 (diff) | |
download | dexon-sol-tools-2ffab2218584fac5d3ea2b264a7c746d963083d9.tar dexon-sol-tools-2ffab2218584fac5d3ea2b264a7c746d963083d9.tar.gz dexon-sol-tools-2ffab2218584fac5d3ea2b264a7c746d963083d9.tar.bz2 dexon-sol-tools-2ffab2218584fac5d3ea2b264a7c746d963083d9.tar.lz dexon-sol-tools-2ffab2218584fac5d3ea2b264a7c746d963083d9.tar.xz dexon-sol-tools-2ffab2218584fac5d3ea2b264a7c746d963083d9.tar.zst dexon-sol-tools-2ffab2218584fac5d3ea2b264a7c746d963083d9.zip |
Merge branch 'v2-prototype' into feature/combinatorial-testing
* v2-prototype: (22 commits)
Fix closing parens in liborder
Update after rebase
ERC721Proxy Always call safeTransferFrom
Rename makerEpoch => orderEpoch
Make cancelOrdersUpTo compatible with sender abstraction
Update PR template
Use Image component instead of img tag
Assembler orderHash function
Optimize and remove redundant encodePacked
Fix linting issue
Fix bug where we do fetch balances on wallet login
Check network state immediately instead of waiting for delay
Fix onboarding persisting when changing routes
Consolidate account state messaging logic
Only elevate wallet zIndex when onboarding is in progress
Rebase and update feedback
Run linter
Add Portal v2 logging
Simplified handling of source < 32 edge case
Basic EIP712 encoder
...
Diffstat (limited to 'PULL_REQUEST_TEMPLATE.md')
-rw-r--r-- | PULL_REQUEST_TEMPLATE.md | 18 |
1 files changed, 2 insertions, 16 deletions
diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 8752069db..34f74b601 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -1,24 +1,10 @@ -<!--- Thank you for taking the time to submit a Pull Request --> - -<!--- Provide a general summary of the issue in the Title above --> - ## Description <!--- Describe your changes in detail --> -## Motivation and Context - -<!--- Why is this change required? What problem does it solve? --> - -<!--- If it fixes an open issue, please link to the issue here. --> - -## How Has This Been Tested? - -<!--- Please describe in detail how you tested your changes. --> - -<!--- Include details of your testing environment, and the tests you ran to --> +## Testing instructions -<!--- see how your change affects other areas of the code, etc. --> +<!--- Please describe how reviewers can test your changes --> ## Types of changes |