diff options
| author | Leonid Logvinov <logvinov.leon@gmail.com> | 2018-02-28 14:34:23 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-02-28 14:34:23 +0800 |
| commit | 5bbb0d1f604a03e72bd10060f1ebf9df33e51f3d (patch) | |
| tree | e2572ed3d98db9d233f66f85242ef2c05540f0de /CONTRIBUTING.md | |
| parent | a5b88753564b327b9e2895c16ec1c71eef7421b2 (diff) | |
| parent | 30e4613d0a5817b880feba3a2c7ad9900c8d287b (diff) | |
| download | dexon-sol-tools-5bbb0d1f604a03e72bd10060f1ebf9df33e51f3d.tar dexon-sol-tools-5bbb0d1f604a03e72bd10060f1ebf9df33e51f3d.tar.gz dexon-sol-tools-5bbb0d1f604a03e72bd10060f1ebf9df33e51f3d.tar.bz2 dexon-sol-tools-5bbb0d1f604a03e72bd10060f1ebf9df33e51f3d.tar.lz dexon-sol-tools-5bbb0d1f604a03e72bd10060f1ebf9df33e51f3d.tar.xz dexon-sol-tools-5bbb0d1f604a03e72bd10060f1ebf9df33e51f3d.tar.zst dexon-sol-tools-5bbb0d1f604a03e72bd10060f1ebf9df33e51f3d.zip | |
Merge pull request #422 from 0xProject/feature/new-prettier
Upgrade prettier
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e8828ff6b..2bb71e855 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -8,9 +8,9 @@ If you'd like to contribute to 0x protocol, please fork the repo, fix, commit an We encourage a “PR early” approach so create the PR as early as possible even without the fix/feature ready, so that devs and other contributors know you have picked up the issue. These early PRs should indicate an 'in progress' status by adding the '[WIP]' prefix to the PR title. Please make sure your contributions adhere to our coding guidelines: -* Pull requests adding features or refactoring should be opened against the `development` branch -* Pull requests fixing bugs in the latest release version should be opened again the `master` branch -* Write [good commit messages](https://chris.beams.io/posts/git-commit/) +* Pull requests adding features or refactoring should be opened against the `development` branch +* Pull requests fixing bugs in the latest release version should be opened again the `master` branch +* Write [good commit messages](https://chris.beams.io/posts/git-commit/) ### Code quality @@ -31,10 +31,10 @@ We also use [Prettier](https://prettier.io/) to auto-format our code. Be sure to If using the Atom text editor, we recommend you install the following packages: -* [atom-typescript](https://atom.io/packages/atom-typescript) -* [linter-tslint](https://atom.io/packages/linter-tslint) -* [prettier-atom](https://atom.io/packages/prettier-atom) -* [language-ethereum](https://atom.io/packages/language-ethereum) +* [atom-typescript](https://atom.io/packages/atom-typescript) +* [linter-tslint](https://atom.io/packages/linter-tslint) +* [prettier-atom](https://atom.io/packages/prettier-atom) +* [language-ethereum](https://atom.io/packages/language-ethereum) Our CI will also run TSLint and Prettier as a part of the test run when you submit your PR. Make sure that the CI tests pass for your contribution. |