aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAmir Bandeali <abandeali1@gmail.com>2018-01-27 01:04:18 +0800
committerGitHub <noreply@github.com>2018-01-27 01:04:18 +0800
commite588f6f8c392bc5b9e843a151f8bdd63fc08dba6 (patch)
tree141d96af4c6ff4d822098dcc698e09c457905259
parentad85011d62ded60a0f4c4d69f2fda0665e12c425 (diff)
parentd227f2ad7ca5128332be7dbb671c5e443789d472 (diff)
downloaddexon-sol-tools-e588f6f8c392bc5b9e843a151f8bdd63fc08dba6.tar
dexon-sol-tools-e588f6f8c392bc5b9e843a151f8bdd63fc08dba6.tar.gz
dexon-sol-tools-e588f6f8c392bc5b9e843a151f8bdd63fc08dba6.tar.bz2
dexon-sol-tools-e588f6f8c392bc5b9e843a151f8bdd63fc08dba6.tar.lz
dexon-sol-tools-e588f6f8c392bc5b9e843a151f8bdd63fc08dba6.tar.xz
dexon-sol-tools-e588f6f8c392bc5b9e843a151f8bdd63fc08dba6.tar.zst
dexon-sol-tools-e588f6f8c392bc5b9e843a151f8bdd63fc08dba6.zip
Merge pull request #338 from joincivil/feature/transaction-receipt
Fix getTransactionReceipt not returning null
-rw-r--r--packages/web3-typescript-typings/CHANGELOG.md1
-rw-r--r--packages/web3-typescript-typings/index.d.ts4
2 files changed, 3 insertions, 2 deletions
diff --git a/packages/web3-typescript-typings/CHANGELOG.md b/packages/web3-typescript-typings/CHANGELOG.md
index 46f70d864..56bb4ed48 100644
--- a/packages/web3-typescript-typings/CHANGELOG.md
+++ b/packages/web3-typescript-typings/CHANGELOG.md
@@ -2,5 +2,6 @@
## v0.9.3 - _January 11, 2018_
+* Fix `getTransactionReceipt` not returning null (#338)
* Add type for getData on a contract
* Fixed the `defaultAccount` not allowing for `undefined` value (#320)
diff --git a/packages/web3-typescript-typings/index.d.ts b/packages/web3-typescript-typings/index.d.ts
index ff379cb3d..cd34759ed 100644
--- a/packages/web3-typescript-typings/index.d.ts
+++ b/packages/web3-typescript-typings/index.d.ts
@@ -257,10 +257,10 @@ declare module 'web3' {
sign(address: string, data: string): string;
sign(address: string, data: string, callback: (err: Error, signature: string) => void): void;
- getTransactionReceipt(txHash: string): Web3.TransactionReceipt;
+ getTransactionReceipt(txHash: string): Web3.TransactionReceipt | null;
getTransactionReceipt(
txHash: string,
- callback: (err: Error, receipt: Web3.TransactionReceipt) => void,
+ callback: (err: Error, receipt: Web3.TransactionReceipt | null) => void,
): void;
// TODO block param