diff options
| author | fragosti <francesco.agosti93@gmail.com> | 2018-12-01 03:20:07 +0800 |
|---|---|---|
| committer | fragosti <francesco.agosti93@gmail.com> | 2018-12-01 03:20:07 +0800 |
| commit | 09813cb1d83da4c571cf69a448c35c5f6af94dec (patch) | |
| tree | f8f448f38a1e7c59a2d0334255bd32b587864e97 | |
| parent | 42e83ae643bbcb04d9c9ccf4c9eca476d055f47a (diff) | |
| download | dexon-sol-tools-09813cb1d83da4c571cf69a448c35c5f6af94dec.tar dexon-sol-tools-09813cb1d83da4c571cf69a448c35c5f6af94dec.tar.gz dexon-sol-tools-09813cb1d83da4c571cf69a448c35c5f6af94dec.tar.bz2 dexon-sol-tools-09813cb1d83da4c571cf69a448c35c5f6af94dec.tar.lz dexon-sol-tools-09813cb1d83da4c571cf69a448c35c5f6af94dec.tar.xz dexon-sol-tools-09813cb1d83da4c571cf69a448c35c5f6af94dec.tar.zst dexon-sol-tools-09813cb1d83da4c571cf69a448c35c5f6af94dec.zip | |
fix: address PR feedback
| -rw-r--r-- | packages/instant/.dogfood.discharge.json | 2 | ||||
| -rw-r--r-- | packages/instant/.staging.discharge.json | 2 | ||||
| -rw-r--r-- | packages/instant/package.json | 1 | ||||
| -rw-r--r-- | packages/instant/src/index.umd.ts | 4 | ||||
| -rw-r--r-- | packages/instant/webpack.config.js | 3 |
5 files changed, 4 insertions, 8 deletions
diff --git a/packages/instant/.dogfood.discharge.json b/packages/instant/.dogfood.discharge.json index ca36b3861..85a48044b 100644 --- a/packages/instant/.dogfood.discharge.json +++ b/packages/instant/.dogfood.discharge.json @@ -1,6 +1,6 @@ { "domain": "0x-instant-dogfood", - "build_command": "WEBPACK_OUTPUT_PATH=public yarn build:umd:prod", + "build_command": "WEBPACK_OUTPUT_PATH=public yarn build", "upload_directory": "public", "index_key": "index.html", "error_key": "index.html", diff --git a/packages/instant/.staging.discharge.json b/packages/instant/.staging.discharge.json index c917a650b..93fd94f40 100644 --- a/packages/instant/.staging.discharge.json +++ b/packages/instant/.staging.discharge.json @@ -1,6 +1,6 @@ { "domain": "0x-instant-staging", - "build_command": "WEBPACK_OUTPUT_PATH=public yarn build:umd:prod", + "build_command": "WEBPACK_OUTPUT_PATH=public yarn build", "upload_directory": "public", "index_key": "index.html", "error_key": "index.html", diff --git a/packages/instant/package.json b/packages/instant/package.json index 427d5984e..4c26d2dae 100644 --- a/packages/instant/package.json +++ b/packages/instant/package.json @@ -10,7 +10,6 @@ "scripts": { "build": "webpack --mode production", "build:ci": "yarn build", - "watch_without_deps": "tsc -w", "dev": "webpack-dev-server --mode development", "lint": "tslint --format stylish --project .", "test": "jest", diff --git a/packages/instant/src/index.umd.ts b/packages/instant/src/index.umd.ts index 45369d9ee..95080f829 100644 --- a/packages/instant/src/index.umd.ts +++ b/packages/instant/src/index.umd.ts @@ -112,5 +112,5 @@ export const render = (config: ZeroExInstantConfig, selector: string = DEFAULT_Z }; // Write version info to the exported object for debugging -export const GitSha = process.env.GIT_SHA; -export const NpmVersion = process.env.NPM_PACKAGE_VERSION; +export const GIT_SHA = process.env.GIT_SHA; +export const NPM_VERSION = process.env.NPM_PACKAGE_VERSION; diff --git a/packages/instant/webpack.config.js b/packages/instant/webpack.config.js index 41276809c..2a517bb59 100644 --- a/packages/instant/webpack.config.js +++ b/packages/instant/webpack.config.js @@ -3,9 +3,6 @@ const ip = require('ip'); const path = require('path'); const webpack = require('webpack'); -// The common js bundle (not this one) is built using tsc. -// The umd bundle (this one) has a different entrypoint. - const GIT_SHA = childProcess .execSync('git rev-parse HEAD') .toString() |