diff options
| author | Fabio Berger <me@fabioberger.com> | 2018-06-13 19:16:22 +0800 |
|---|---|---|
| committer | Fabio Berger <me@fabioberger.com> | 2018-06-13 19:16:22 +0800 |
| commit | 38de1c9a315aec7f43b08d372dd2360c09bd0acd (patch) | |
| tree | 605a8bb03c534e809c75bbb3d8db99199f21ed33 | |
| parent | 78dcb87a7501e9076570b3ed9de2a43b924299f3 (diff) | |
| download | dexon-sol-tools-38de1c9a315aec7f43b08d372dd2360c09bd0acd.tar dexon-sol-tools-38de1c9a315aec7f43b08d372dd2360c09bd0acd.tar.gz dexon-sol-tools-38de1c9a315aec7f43b08d372dd2360c09bd0acd.tar.bz2 dexon-sol-tools-38de1c9a315aec7f43b08d372dd2360c09bd0acd.tar.lz dexon-sol-tools-38de1c9a315aec7f43b08d372dd2360c09bd0acd.tar.xz dexon-sol-tools-38de1c9a315aec7f43b08d372dd2360c09bd0acd.tar.zst dexon-sol-tools-38de1c9a315aec7f43b08d372dd2360c09bd0acd.zip | |
Remove comment since we have added the tests
| -rw-r--r-- | packages/order-utils/src/order_validation_utils.ts | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/packages/order-utils/src/order_validation_utils.ts b/packages/order-utils/src/order_validation_utils.ts index 3a6704f26..ab471b455 100644 --- a/packages/order-utils/src/order_validation_utils.ts +++ b/packages/order-utils/src/order_validation_utils.ts @@ -14,11 +14,6 @@ import { utils } from './utils'; export class OrderValidationUtils { private _exchangeContract: ExchangeContract; - // TODO: Write some tests for the function - // const numerator = new BigNumber(20); - // const denominator = new BigNumber(999); - // const target = new BigNumber(50); - // rounding error = ((20*50/999) - floor(20*50/999)) / (20*50/999) = 0.1% public static isRoundingError(numerator: BigNumber, denominator: BigNumber, target: BigNumber): boolean { // Solidity's mulmod() in JS // Source: https://solidity.readthedocs.io/en/latest/units-and-global-variables.html#mathematical-and-cryptographic-functions |