diff options
author | Fabio Berger <me@fabioberger.com> | 2018-04-19 13:14:10 +0800 |
---|---|---|
committer | Fabio Berger <me@fabioberger.com> | 2018-04-19 13:14:10 +0800 |
commit | 858d1768cecf165adefcdf860f247dad258d8cae (patch) | |
tree | 96d5c5a574892bbda193242585a4090a63102cbe | |
parent | fc2b7f747bf15b8c9329f2940ed2f6cf71353c33 (diff) | |
download | dexon-sol-tools-858d1768cecf165adefcdf860f247dad258d8cae.tar dexon-sol-tools-858d1768cecf165adefcdf860f247dad258d8cae.tar.gz dexon-sol-tools-858d1768cecf165adefcdf860f247dad258d8cae.tar.bz2 dexon-sol-tools-858d1768cecf165adefcdf860f247dad258d8cae.tar.lz dexon-sol-tools-858d1768cecf165adefcdf860f247dad258d8cae.tar.xz dexon-sol-tools-858d1768cecf165adefcdf860f247dad258d8cae.tar.zst dexon-sol-tools-858d1768cecf165adefcdf860f247dad258d8cae.zip |
Improve comments
-rw-r--r-- | packages/monorepo-scripts/src/publish.ts | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/packages/monorepo-scripts/src/publish.ts b/packages/monorepo-scripts/src/publish.ts index 9bd9ff6be..827d6165e 100644 --- a/packages/monorepo-scripts/src/publish.ts +++ b/packages/monorepo-scripts/src/publish.ts @@ -113,7 +113,7 @@ package.ts. Please add an entry for it and try again.`, } async function checkPublishRequiredSetupAsync(): Promise<boolean> { - // check to see if logged into npm before publishing (npm whoami) + // check to see if logged into npm before publishing try { await execAsync(`sudo npm whoami`); } catch (err) { @@ -121,13 +121,14 @@ async function checkPublishRequiredSetupAsync(): Promise<boolean> { return false; } - // Check to see if Git creds setup (check for ENV 'GITHUB_PERSONAL_ACCESS_TOKEN_0X_JS') + // Check to see if Git personal token setup if (_.isUndefined(process.env.GITHUB_PERSONAL_ACCESS_TOKEN_0X_JS)) { utils.log( 'You must have a Github personal access token set to an envVar named `GITHUB_PERSONAL_ACCESS_TOKEN_0X_JS`. Add it then try again.', ); return false; } + // Check NPM version is 5.X const result = await execAsync(`npm --version`); const version = result.stdout; @@ -138,7 +139,7 @@ async function checkPublishRequiredSetupAsync(): Promise<boolean> { return false; } - // Check that `aws` commandline is installed + // Check that `aws` commandline tool is installed try { await execAsync(`aws help`); } catch (err) { @@ -146,7 +147,7 @@ async function checkPublishRequiredSetupAsync(): Promise<boolean> { return false; } - // Check that `aws` creds are setup + // Check that `aws` credentials are setup try { await execAsync(`aws sts get-caller-identity`); } catch (err) { |