aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFabio Berger <me@fabioberger.com>2018-11-19 22:34:21 +0800
committerFabio Berger <me@fabioberger.com>2018-11-19 22:34:21 +0800
commit4cb138ab37aee5c91ff70a178dda1abf5c1dfc39 (patch)
treecbb4f16085ee3c4831eb4208d98dcbb19955270f
parent8b8e277b7553c42b019f56822ffa5fd05dab2951 (diff)
downloaddexon-sol-tools-4cb138ab37aee5c91ff70a178dda1abf5c1dfc39.tar
dexon-sol-tools-4cb138ab37aee5c91ff70a178dda1abf5c1dfc39.tar.gz
dexon-sol-tools-4cb138ab37aee5c91ff70a178dda1abf5c1dfc39.tar.bz2
dexon-sol-tools-4cb138ab37aee5c91ff70a178dda1abf5c1dfc39.tar.lz
dexon-sol-tools-4cb138ab37aee5c91ff70a178dda1abf5c1dfc39.tar.xz
dexon-sol-tools-4cb138ab37aee5c91ff70a178dda1abf5c1dfc39.tar.zst
dexon-sol-tools-4cb138ab37aee5c91ff70a178dda1abf5c1dfc39.zip
Fixes to CONTRIBUTING.md
-rw-r--r--CONTRIBUTING.md6
1 files changed, 3 insertions, 3 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 6933a1162..1fea8f501 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -16,7 +16,7 @@ Before removing the `[WIP]` tag and submitting the PR for review, make sure:
* It is properly formatted with Prettier (`yarn prettier`)
* It passes our continuous integration tests (See: [Enabling code coverage checks on your fork](#enabling-code-coverage-checks-on-your-fork) for instructions on getting the `submit-coverage` test to pass on forks)
* You've created/updated the corresponding [CHANGELOG](#CHANGELOGs) entries.
-* Your changes have sufficient test coverage (e.g regression tests for bug fixes)
+* Your changes have sufficient test coverage (e.g regression tests have been added for bug fixes)
### Branch structure
@@ -35,13 +35,13 @@ Branch names should be prefixed with `fix`, `feature` or `refactor`.
### CHANGELOGs
-At 0x we use [Semantic Versioning](http://semver.org/) for all our published packages. If a change you make is a bug fix, adds a feature or introduces a breaking change to a package, you must modify it's `CHANGELOG.json` file accordingly.
+At 0x we use [Semantic Versioning](http://semver.org/) for all our published packages. If a change you make corresponds to a semver bump, you must modify the package's `CHANGELOG.json` file accordingly.
Each CHANGELOG entry that corresponds to a published package will have a `timestamp`. If no entry exists without a `timestamp`, you must first create a new one:
```
{
- "version": "1.0.0", <- The updated package version
+ "version": "1.0.1", <- The updated package version
"changes": [
{
"note": "", <- Describe your change