Add no-op test

2 files changed, 6 insertions, 4 deletions

diff --git a/src/contract_wrappers/exchange_wrapper.ts b/src/contract_wrappers/exchange_wrapper.ts
index c304aeb08..a15df5a77 100644
--- a/src/contract_wrappers/exchange_wrapper.ts
+++ b/src/contract_wrappers/exchange_wrapper.ts
@@ -144,7 +144,9 @@ export class ExchangeWrapper extends ContractWrapper {
      */
     public async batchFillOrderAsync(orderFillRequests: OrderFillRequest[],
                                      shouldCheckTransfer: boolean, takerAddress: string): Promise<void> {
-        assert.assert(!_.isEmpty(orderFillRequests), 'Cannot fill an empty batch');
+        if (_.isEmpty(orderFillRequests)) {
+            return;
+        }
         assert.isBoolean('shouldCheckTransfer', shouldCheckTransfer);
         await assert.isSenderAddressAsync('takerAddress', takerAddress, this.web3Wrapper);
         _.forEach(orderFillRequests,
diff --git a/test/exchange_wrapper_test.ts b/test/exchange_wrapper_test.ts
index 748816949..bd2536741 100644
--- a/test/exchange_wrapper_test.ts
+++ b/test/exchange_wrapper_test.ts
@@ -348,10 +348,10 @@ describe('ExchangeWrapper', () => {
                     },
                 ];
             });
-            describe('failed batch fills', () => {
-
-            });
             describe('successful batch fills', () => {
+                it('should no-op for an empty batch', async () => {
+                    await zeroEx.exchange.batchFillOrderAsync([], shouldCheckTransfer, takerAddress);
+                });
                 it('should successfully fill multiple orders', async () => {
                     await zeroEx.exchange.batchFillOrderAsync(orderFillBatch, shouldCheckTransfer, takerAddress);
                     const filledAmount = await zeroEx.exchange.getFilledTakerAmountAsync(signedOrderHashHex);