aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFabio Berger <me@fabioberger.com>2017-11-09 07:59:59 +0800
committerFabio Berger <me@fabioberger.com>2017-11-09 07:59:59 +0800
commitee3115550e26b276c35b33fed085f46a08ca05d5 (patch)
tree56681d764d96f1c646e53367327204cc1961f4a9
parentd39852c0cf8112015235e938df16a481e84b9ab0 (diff)
downloaddexon-sol-tools-ee3115550e26b276c35b33fed085f46a08ca05d5.tar
dexon-sol-tools-ee3115550e26b276c35b33fed085f46a08ca05d5.tar.gz
dexon-sol-tools-ee3115550e26b276c35b33fed085f46a08ca05d5.tar.bz2
dexon-sol-tools-ee3115550e26b276c35b33fed085f46a08ca05d5.tar.lz
dexon-sol-tools-ee3115550e26b276c35b33fed085f46a08ca05d5.tar.xz
dexon-sol-tools-ee3115550e26b276c35b33fed085f46a08ca05d5.tar.zst
dexon-sol-tools-ee3115550e26b276c35b33fed085f46a08ca05d5.zip
Add todo comments
-rw-r--r--src/mempool/event_watcher.ts2
-rw-r--r--src/utils/abi_decoder.ts2
2 files changed, 3 insertions, 1 deletions
diff --git a/src/mempool/event_watcher.ts b/src/mempool/event_watcher.ts
index ac07badfe..cb8921cfd 100644
--- a/src/mempool/event_watcher.ts
+++ b/src/mempool/event_watcher.ts
@@ -47,6 +47,7 @@ export class EventWatcher {
this._lastMempoolEvents = pendingEvents;
}
private async _getMempoolEventsAsync(): Promise<Web3.LogEntry[]> {
+ // TODO: Allow users to listen to any number of confirmations deep, not just mempool
const mempoolFilter = {
fromBlock: BlockParamLiteral.Pending,
toBlock: BlockParamLiteral.Pending,
@@ -54,6 +55,7 @@ export class EventWatcher {
const pendingEvents = await this._web3Wrapper.getLogsAsync(mempoolFilter);
return pendingEvents;
}
+ // TODO: Let's emit out own LogEntry type that has property isRemoved rather then removed
private async _emitDifferencesAsync(logs: Web3.LogEntry[], isRemoved: boolean): Promise<void> {
for (const log of logs) {
const logEvent = {
diff --git a/src/utils/abi_decoder.ts b/src/utils/abi_decoder.ts
index 247ba0e5b..840ad9be0 100644
--- a/src/utils/abi_decoder.ts
+++ b/src/utils/abi_decoder.ts
@@ -10,7 +10,7 @@ export class AbiDecoder {
constructor(abiArrays: Web3.AbiDefinition[][]) {
_.map(abiArrays, this.addABI.bind(this));
}
- // This method can only decode logs from the 0x smart contracts
+ // This method can only decode logs from the 0x & ERC20 smart contracts
public tryToDecodeLogOrNoop<ArgsType extends ContractEventArgs>(
log: Web3.LogEntry): LogWithDecodedArgs<ArgsType>|RawLog {
const methodId = log.topics[0];