diff options
| author | Fabio Berger <me@fabioberger.com> | 2017-06-01 23:39:58 +0800 |
|---|---|---|
| committer | Fabio Berger <me@fabioberger.com> | 2017-06-01 23:39:58 +0800 |
| commit | 85d4badbd6141bed4f7f00c08e882eb8db362252 (patch) | |
| tree | ad9db3f4c1165a7c7585881c2ebc9ec9b31b31d0 | |
| parent | 3a4020c78b9b22a52db0f964ac20ced905fa1bcd (diff) | |
| download | dexon-sol-tools-85d4badbd6141bed4f7f00c08e882eb8db362252.tar dexon-sol-tools-85d4badbd6141bed4f7f00c08e882eb8db362252.tar.gz dexon-sol-tools-85d4badbd6141bed4f7f00c08e882eb8db362252.tar.bz2 dexon-sol-tools-85d4badbd6141bed4f7f00c08e882eb8db362252.tar.lz dexon-sol-tools-85d4badbd6141bed4f7f00c08e882eb8db362252.tar.xz dexon-sol-tools-85d4badbd6141bed4f7f00c08e882eb8db362252.tar.zst dexon-sol-tools-85d4badbd6141bed4f7f00c08e882eb8db362252.zip | |
remove unused arg
| -rw-r--r-- | test/exchange_wrapper_test.ts | 10 | ||||
| -rw-r--r-- | test/utils/order_factory.ts | 1 |
2 files changed, 4 insertions, 7 deletions
diff --git a/test/exchange_wrapper_test.ts b/test/exchange_wrapper_test.ts index 091d23fca..e74cdacaf 100644 --- a/test/exchange_wrapper_test.ts +++ b/test/exchange_wrapper_test.ts @@ -107,7 +107,6 @@ describe('ExchangeWrapper', () => { const fillAmount = new BigNumber(5); let maker: string; let taker: string; - let networkId: number; const addressBySymbol: {[symbol: string]: string} = {}; const shouldCheckTransfer = false; before('fetch tokens', async () => { @@ -115,7 +114,6 @@ describe('ExchangeWrapper', () => { _.forEach(tokens, token => { addressBySymbol[token.symbol] = token.address; }); - networkId = await promisify(web3.version.getNetwork)(); }); beforeEach('setup', async () => { maker = userAddresses[0]; @@ -131,7 +129,7 @@ describe('ExchangeWrapper', () => { it('should throw when the fill amount is zero', async () => { const makerAmount = 5; const takerAmount = 5; - const signedOrder = await orderFactory.createSignedOrderAsync(zeroEx, networkId, maker, taker, + const signedOrder = await orderFactory.createSignedOrderAsync(zeroEx, maker, taker, makerAmount, addressBySymbol.MLN, takerAmount, addressBySymbol.GNT); const zeroFillAmount = new BigNumber(0); zeroEx.setDefaultAccount(taker); @@ -141,7 +139,7 @@ describe('ExchangeWrapper', () => { it('should throw when sender is not a taker', async () => { const makerAmount = 5; const takerAmount = 5; - const signedOrder = await orderFactory.createSignedOrderAsync(zeroEx, networkId, maker, taker, + const signedOrder = await orderFactory.createSignedOrderAsync(zeroEx, maker, taker, makerAmount, addressBySymbol.MLN, takerAmount, addressBySymbol.GNT); expect(zeroEx.exchange.fillOrderAsync(signedOrder, fillAmount, shouldCheckTransfer)) .to.be.rejectedWith(FillOrderValidationErrs.NOT_A_TAKER); @@ -150,7 +148,7 @@ describe('ExchangeWrapper', () => { const OLD_TIMESTAMP = new BigNumber(42); const makerAmount = 5; const takerAmount = 5; - const signedOrder = await orderFactory.createSignedOrderAsync(zeroEx, networkId, maker, taker, + const signedOrder = await orderFactory.createSignedOrderAsync(zeroEx, maker, taker, makerAmount, addressBySymbol.MLN, takerAmount, addressBySymbol.GNT, OLD_TIMESTAMP); zeroEx.setDefaultAccount(taker); expect(zeroEx.exchange.fillOrderAsync(signedOrder, fillAmount, shouldCheckTransfer)) @@ -161,7 +159,7 @@ describe('ExchangeWrapper', () => { it('should fill the valid order', async () => { const makerAmount = 5; const takerAmount = 5; - const signedOrder = await orderFactory.createSignedOrderAsync(zeroEx, networkId, maker, taker, + const signedOrder = await orderFactory.createSignedOrderAsync(zeroEx, maker, taker, makerAmount, addressBySymbol.MLN, takerAmount, addressBySymbol.GNT); zeroEx.setDefaultAccount(taker); await zeroEx.exchange.fillOrderAsync(signedOrder, fillAmount, shouldCheckTransfer); diff --git a/test/utils/order_factory.ts b/test/utils/order_factory.ts index c0d70f39b..359168ff9 100644 --- a/test/utils/order_factory.ts +++ b/test/utils/order_factory.ts @@ -8,7 +8,6 @@ import * as ExchangeArtifacts from '../../src/artifacts/Exchange.json'; export const orderFactory = { async createSignedOrderAsync( zeroEx: ZeroEx, - networkId: number, maker: string, taker: string, makerTokenAmount: BigNumber.BigNumber|number, |