diff options
| author | Brandon Millman <brandon@0xproject.com> | 2018-11-07 14:53:09 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-11-07 14:53:09 +0800 |
| commit | 094f71066294d14bc1920e4d3ddf4e7705201d61 (patch) | |
| tree | 3796e1aa4d94c1d435ac3a825b32e4ef71da73d0 | |
| parent | ce4081bb18bffb364050f04796f3174b87b7303e (diff) | |
| parent | 0823bd24d6e6a69fcd8638852f1b93eebd7d68b3 (diff) | |
| download | dexon-sol-tools-094f71066294d14bc1920e4d3ddf4e7705201d61.tar dexon-sol-tools-094f71066294d14bc1920e4d3ddf4e7705201d61.tar.gz dexon-sol-tools-094f71066294d14bc1920e4d3ddf4e7705201d61.tar.bz2 dexon-sol-tools-094f71066294d14bc1920e4d3ddf4e7705201d61.tar.lz dexon-sol-tools-094f71066294d14bc1920e4d3ddf4e7705201d61.tar.xz dexon-sol-tools-094f71066294d14bc1920e4d3ddf4e7705201d61.tar.zst dexon-sol-tools-094f71066294d14bc1920e4d3ddf4e7705201d61.zip | |
Merge pull request #1217 from 0xProject/fix/asset-buyer/lower-default-expiry-buffer
[asset-buyer] Lower default expiryBuffer from 5 minutes to 2 minutes
| -rw-r--r-- | packages/asset-buyer/CHANGELOG.json | 4 | ||||
| -rw-r--r-- | packages/asset-buyer/src/constants.ts | 2 |
2 files changed, 5 insertions, 1 deletions
diff --git a/packages/asset-buyer/CHANGELOG.json b/packages/asset-buyer/CHANGELOG.json index 0d71bb84d..2a775075f 100644 --- a/packages/asset-buyer/CHANGELOG.json +++ b/packages/asset-buyer/CHANGELOG.json @@ -24,6 +24,10 @@ "note": "Fix bug where default values for `AssetBuyer` public facing methods could get overriden by `undefined` values", "pr": 1207 + }, + { + "note": "Lower default expiry buffer from 5 minutes to 2 minutes", + "pr": 1217 } ] }, diff --git a/packages/asset-buyer/src/constants.ts b/packages/asset-buyer/src/constants.ts index cc415102c..c0e1bf27d 100644 --- a/packages/asset-buyer/src/constants.ts +++ b/packages/asset-buyer/src/constants.ts @@ -9,7 +9,7 @@ const MAINNET_NETWORK_ID = 1; const DEFAULT_ASSET_BUYER_OPTS: AssetBuyerOpts = { networkId: MAINNET_NETWORK_ID, orderRefreshIntervalMs: 10000, // 10 seconds - expiryBufferSeconds: 300, // 5 minutes + expiryBufferSeconds: 120, // 2 minutes }; const DEFAULT_BUY_QUOTE_REQUEST_OPTS: BuyQuoteRequestOpts = { |