aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBrandon Millman <brandon.millman@gmail.com>2018-08-10 05:49:22 +0800
committerBrandon Millman <brandon.millman@gmail.com>2018-08-10 07:12:42 +0800
commitc0924d8067079f246c5cad32f7acb3d1f6cfd9b9 (patch)
tree8ea68819655370269ead5be0d208fde4142c6a47
parenta1860b076d9d3408e64d8ff5e6bc0657e9ff7e7b (diff)
downloaddexon-sol-tools-c0924d8067079f246c5cad32f7acb3d1f6cfd9b9.tar
dexon-sol-tools-c0924d8067079f246c5cad32f7acb3d1f6cfd9b9.tar.gz
dexon-sol-tools-c0924d8067079f246c5cad32f7acb3d1f6cfd9b9.tar.bz2
dexon-sol-tools-c0924d8067079f246c5cad32f7acb3d1f6cfd9b9.tar.lz
dexon-sol-tools-c0924d8067079f246c5cad32f7acb3d1f6cfd9b9.tar.xz
dexon-sol-tools-c0924d8067079f246c5cad32f7acb3d1f6cfd9b9.tar.zst
dexon-sol-tools-c0924d8067079f246c5cad32f7acb3d1f6cfd9b9.zip
Implement sorting utils
-rw-r--r--packages/order-utils/src/index.ts1
-rw-r--r--packages/order-utils/src/sorting_utils.ts69
2 files changed, 70 insertions, 0 deletions
diff --git a/packages/order-utils/src/index.ts b/packages/order-utils/src/index.ts
index a52f936b6..359954641 100644
--- a/packages/order-utils/src/index.ts
+++ b/packages/order-utils/src/index.ts
@@ -34,3 +34,4 @@ export { OrderValidationUtils } from './order_validation_utils';
export { ExchangeTransferSimulator } from './exchange_transfer_simulator';
export { marketUtils } from './market_utils';
export { rateUtils } from './rate_utils';
+export { sortingUtils } from './sorting_utils';
diff --git a/packages/order-utils/src/sorting_utils.ts b/packages/order-utils/src/sorting_utils.ts
new file mode 100644
index 000000000..7474a302f
--- /dev/null
+++ b/packages/order-utils/src/sorting_utils.ts
@@ -0,0 +1,69 @@
+import { schemas } from '@0xproject/json-schemas';
+import { SignedOrder } from '@0xproject/types';
+import { BigNumber } from '@0xproject/utils';
+import * as _ from 'lodash';
+
+import { assert } from './assert';
+import { constants } from './constants';
+import { rateUtils } from './rate_utils';
+
+export const sortingUtils = {
+ /**
+ * Takes an array of signed orders and sorts them by takerAsset/makerAsset rate in ascending order (best rate first).
+ * Adjusts the rate of each order according to the feeRate and takerFee for that order.
+ * @param signedFeeOrders An array of objects that conform to the SignedOrder interface. All orders should specify ZRX as
+ * the makerAsset and WETH as the takerAsset.
+ * @param feeRate The market rate of ZRX denominated in takerAssetAmount
+ * (ex. feeRate is 0.1 takerAsset/ZRX if it takes 1 unit of takerAsset to buy 10 ZRX)
+ * @return The input orders sorted by rate in ascending order
+ */
+ sortOrdersByFeeAdjustedRate(signedOrders: SignedOrder[], feeRate: BigNumber): SignedOrder[] {
+ assert.doesConformToSchema('signedOrders', signedOrders, schemas.signedOrdersSchema);
+ assert.isBigNumber('feeRate', feeRate);
+ assert.assert(feeRate.greaterThan(constants.ZERO_AMOUNT), `Expected feeRate: ${feeRate} to be greater than 0`);
+ const rateCalculator = (signedOrder: SignedOrder) => rateUtils.getFeeAdjustedRateOfOrder(signedOrder, feeRate);
+ const sortedOrders = sortOrders(signedOrders, rateCalculator);
+ return sortedOrders;
+ },
+ /**
+ * Takes an array of signed fee orders (makerAssetData corresponds to ZRX and takerAssetData corresponds to WETH)
+ * and sorts them by rate in ascending order (best rate first). Adjusts the rate according to the takerFee.
+ * @param signedFeeOrders An array of objects that conform to the SignedOrder interface. All orders should specify ZRX as
+ * the makerAsset and WETH as the takerAsset.
+ * @return The input orders sorted by rate in ascending order
+ */
+ sortFeeOrdersByFeeAdjustedRate(signedFeeOrders: SignedOrder[]): SignedOrder[] {
+ assert.doesConformToSchema('signedFeeOrders', signedFeeOrders, schemas.signedOrdersSchema);
+ const rateCalculator = rateUtils.getFeeAdjustedRateOfFeeOrder;
+ const sortedOrders = sortOrders(signedFeeOrders, rateCalculator);
+ return sortedOrders;
+ },
+};
+
+type RateCalculator = (signedOrder: SignedOrder) => BigNumber;
+
+// takes an array of orders, copies them, and sorts the copy based on the rate definition provided by rateCalculator
+const sortOrders = (signedOrders: SignedOrder[], rateCalculator: RateCalculator): SignedOrder[] => {
+ const copiedOrders = _.cloneDeep(signedOrders);
+ const feeOrderComparator = getOrderComparator(rateCalculator);
+ copiedOrders.sort(feeOrderComparator);
+ return copiedOrders;
+};
+
+type Comparator<T> = (first: T, second: T) => number;
+
+// takes a function that calculates rate for a signed order and returns a comparator that sorts based on rate
+const getOrderComparator = (rateCalculator: RateCalculator): Comparator<SignedOrder> => (
+ firstSignedOrder,
+ secondSignedOrder,
+) => {
+ const firstOrderRate = rateCalculator(firstSignedOrder);
+ const secondOrderRate = rateCalculator(secondSignedOrder);
+ if (firstOrderRate.lt(secondOrderRate)) {
+ return -1;
+ } else if (firstOrderRate.gt(secondOrderRate)) {
+ return 1;
+ } else {
+ return 0;
+ }
+};