aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBrandon Millman <brandon@0xproject.com>2017-12-22 10:04:50 +0800
committerGitHub <noreply@github.com>2017-12-22 10:04:50 +0800
commitcbf06b2165715aaadf1afb6fb84040837a7a8827 (patch)
tree1fee6536a033352e2b45917d2a3d66ef4dbe79af
parente884eb9882246398eb576b809e2d18e589ec5f51 (diff)
parentf8cbfea4a19bb5f55a7450e7817281b986365431 (diff)
downloaddexon-sol-tools-cbf06b2165715aaadf1afb6fb84040837a7a8827.tar
dexon-sol-tools-cbf06b2165715aaadf1afb6fb84040837a7a8827.tar.gz
dexon-sol-tools-cbf06b2165715aaadf1afb6fb84040837a7a8827.tar.bz2
dexon-sol-tools-cbf06b2165715aaadf1afb6fb84040837a7a8827.tar.lz
dexon-sol-tools-cbf06b2165715aaadf1afb6fb84040837a7a8827.tar.xz
dexon-sol-tools-cbf06b2165715aaadf1afb6fb84040837a7a8827.tar.zst
dexon-sol-tools-cbf06b2165715aaadf1afb6fb84040837a7a8827.zip
Merge pull request #289 from 0xProject/fix/missingBigNumberConfigs
Add missing calls to bigNumberConfigs in packages where we are instan…
-rw-r--r--packages/connect/package.json1
-rw-r--r--packages/connect/src/http_client.ts6
-rw-r--r--packages/connect/src/index.ts5
-rw-r--r--packages/web3-wrapper/src/index.ts8
4 files changed, 13 insertions, 7 deletions
diff --git a/packages/connect/package.json b/packages/connect/package.json
index bf92f07d2..5daac8aae 100644
--- a/packages/connect/package.json
+++ b/packages/connect/package.json
@@ -38,6 +38,7 @@
"dependencies": {
"@0xproject/assert": "^0.0.8",
"@0xproject/json-schemas": "^0.7.0",
+ "@0xproject/utils": "^0.1.1",
"bignumber.js": "~4.1.0",
"isomorphic-fetch": "^2.2.1",
"lodash": "^4.17.4",
diff --git a/packages/connect/src/http_client.ts b/packages/connect/src/http_client.ts
index 3bada2be0..924421f63 100644
--- a/packages/connect/src/http_client.ts
+++ b/packages/connect/src/http_client.ts
@@ -1,6 +1,5 @@
import {assert} from '@0xproject/assert';
import {schemas} from '@0xproject/json-schemas';
-import {BigNumber} from 'bignumber.js';
import 'isomorphic-fetch';
import * as _ from 'lodash';
import * as queryString from 'query-string';
@@ -21,11 +20,6 @@ import {
} from './types';
import {typeConverters} from './utils/type_converters';
-// TODO: move this and bigNumberConfigs in the 0x.js package into one place
-BigNumber.config({
- EXPONENTIAL_AT: 1000,
-});
-
/**
* This class includes all the functionality related to interacting with a set of HTTP endpoints
* that implement the standard relayer API v0
diff --git a/packages/connect/src/index.ts b/packages/connect/src/index.ts
index ec369a606..c0f847d09 100644
--- a/packages/connect/src/index.ts
+++ b/packages/connect/src/index.ts
@@ -1,3 +1,8 @@
+import {bigNumberConfigs} from '@0xproject/utils';
+
+// Customize our BigNumber instances
+bigNumberConfigs.configure();
+
export {HttpClient} from './http_client';
export {WebSocketOrderbookChannel} from './ws_orderbook_channel';
export {
diff --git a/packages/web3-wrapper/src/index.ts b/packages/web3-wrapper/src/index.ts
index dd94d683e..b48532204 100644
--- a/packages/web3-wrapper/src/index.ts
+++ b/packages/web3-wrapper/src/index.ts
@@ -1,5 +1,8 @@
import {TransactionReceipt, TxData} from '@0xproject/types';
-import {promisify} from '@0xproject/utils';
+import {
+ bigNumberConfigs,
+ promisify,
+} from '@0xproject/utils';
import BigNumber from 'bignumber.js';
import * as _ from 'lodash';
import * as Web3 from 'web3';
@@ -15,6 +18,9 @@ interface RawLogEntry {
topics: string[];
}
+// Customize our BigNumber instances
+bigNumberConfigs.configure();
+
export class Web3Wrapper {
private _web3: Web3;
private _defaults: Partial<TxData>;