aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFabio Berger <me@fabioberger.com>2017-05-25 18:08:49 +0800
committerFabio Berger <me@fabioberger.com>2017-05-25 18:08:49 +0800
commitbcfb1a699a8c4469649af721875d878290198899 (patch)
tree0708b871b777a970565e939734dd25082c69eeb2
parentae47981669e4c471623f22f8ecee93709dfe47bd (diff)
downloaddexon-sol-tools-bcfb1a699a8c4469649af721875d878290198899.tar
dexon-sol-tools-bcfb1a699a8c4469649af721875d878290198899.tar.gz
dexon-sol-tools-bcfb1a699a8c4469649af721875d878290198899.tar.bz2
dexon-sol-tools-bcfb1a699a8c4469649af721875d878290198899.tar.lz
dexon-sol-tools-bcfb1a699a8c4469649af721875d878290198899.tar.xz
dexon-sol-tools-bcfb1a699a8c4469649af721875d878290198899.tar.zst
dexon-sol-tools-bcfb1a699a8c4469649af721875d878290198899.zip
Fix malformed tests to check for thrown assertion
-rw-r--r--test/0x.js.ts37
1 files changed, 27 insertions, 10 deletions
diff --git a/test/0x.js.ts b/test/0x.js.ts
index 71126c7da..644bc63b2 100644
--- a/test/0x.js.ts
+++ b/test/0x.js.ts
@@ -13,15 +13,19 @@ describe('ZeroEx library', () => {
s: '0x2d887fd3b17bfdce3481f10bea41f45ba9f709d39ce8325427b57afcfc994cee',
};
const address = '0x9b2055d370f73ec7d8a03e965129118dc8f5bf83';
- describe('should return false for malformed signature', () => {
+ describe('should throw if passed a malformed signature', () => {
it('malformed v', () => {
const malformedSignature = {
v: 34,
r: signature.r,
s: signature.s,
};
- const isValid = ZeroEx.isValidSignature(data, malformedSignature, address);
- expect(isValid).to.be.false;
+ try {
+ const isValid = ZeroEx.isValidSignature(data, malformedSignature, address);
+ throw new Error('isValidSignature should have thrown');
+ } catch (err) {
+ // continue
+ }
});
it('r lacks 0x prefix', () => {
const malformedR = signature.r.replace('0x', '');
@@ -30,18 +34,27 @@ describe('ZeroEx library', () => {
r: malformedR,
s: signature.s,
};
- const isValid = ZeroEx.isValidSignature(data, malformedSignature, address);
- expect(isValid).to.be.false;
+ try {
+ const isValid = ZeroEx.isValidSignature(data, malformedSignature, address);
+ throw new Error('isValidSignature should have thrown');
+ } catch (err) {
+ // continue
+ }
});
it('r is too short', () => {
const malformedR = signature.r.substr(10);
const malformedSignature = {
v: signature.v,
r: malformedR,
- s: signature.s,
+ s: signature.s.replace('0', 'z'),
};
- const isValid = ZeroEx.isValidSignature(data, malformedSignature, address);
- expect(isValid).to.be.false;
+ try {
+ const isValid = ZeroEx.isValidSignature(data, malformedSignature, address);
+ throw new Error('isValidSignature should have thrown');
+ } catch (err) {
+ console.log(err);
+ // continue
+ }
});
it('s is not hex', () => {
const malformedS = signature.s.replace('0', 'z');
@@ -50,8 +63,12 @@ describe('ZeroEx library', () => {
r: signature.r,
s: malformedS,
};
- const isValid = ZeroEx.isValidSignature(data, malformedSignature, address);
- expect(isValid).to.be.false;
+ try {
+ const isValid = ZeroEx.isValidSignature(data, malformedSignature, address);
+ throw new Error('isValidSignature should have thrown');
+ } catch (err) {
+ // continue
+ }
});
});
it('should return false if the data doesn\'t pertain to the signature & address', () => {