aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCavan Flynn <cavan.m.flynn@gmail.com>2017-12-28 08:48:58 +0800
committerGitHub <noreply@github.com>2017-12-28 08:48:58 +0800
commit6ea8cee551f4d5e1ce4986975892f98800b7cc9b (patch)
tree56c2b6d106d6d432cb18a2f037e4e47b2f499012
parent69806c88395c0b7fc174d6f37a83da07a0171fb9 (diff)
downloaddexon-sol-tools-6ea8cee551f4d5e1ce4986975892f98800b7cc9b.tar
dexon-sol-tools-6ea8cee551f4d5e1ce4986975892f98800b7cc9b.tar.gz
dexon-sol-tools-6ea8cee551f4d5e1ce4986975892f98800b7cc9b.tar.bz2
dexon-sol-tools-6ea8cee551f4d5e1ce4986975892f98800b7cc9b.tar.lz
dexon-sol-tools-6ea8cee551f4d5e1ce4986975892f98800b7cc9b.tar.xz
dexon-sol-tools-6ea8cee551f4d5e1ce4986975892f98800b7cc9b.tar.zst
dexon-sol-tools-6ea8cee551f4d5e1ce4986975892f98800b7cc9b.zip
Update subprovider to catch correct RPC method
ZeroEx uses web3.eth.sign, rather than web3.eth.personal.sign. In addition, the message to sign is the second parameter; not the first. The first parameter is the address.
-rw-r--r--packages/subproviders/src/subproviders/ledger.ts4
1 files changed, 2 insertions, 2 deletions
diff --git a/packages/subproviders/src/subproviders/ledger.ts b/packages/subproviders/src/subproviders/ledger.ts
index f19e6fadd..653d0a792 100644
--- a/packages/subproviders/src/subproviders/ledger.ts
+++ b/packages/subproviders/src/subproviders/ledger.ts
@@ -106,8 +106,8 @@ export class LedgerSubprovider extends Subprovider {
}
return;
- case 'personal_sign':
- const data = payload.params[0];
+ case 'eth_sign':
+ const data = payload.params[1];
try {
if (_.isUndefined(data)) {
throw new Error(LedgerSubproviderErrors.DataMissingForSignPersonalMessage);