diff options
author | Amir Bandeali <abandeali1@gmail.com> | 2018-05-30 02:22:57 +0800 |
---|---|---|
committer | Amir Bandeali <abandeali1@gmail.com> | 2018-05-31 08:11:31 +0800 |
commit | 8f2fd9b603f74aa8a44dc0e8c3b845d497f9b279 (patch) | |
tree | da8c19511a2f193a3ddd08f6ce86936ca1c0dbcd | |
parent | d625b65a095381c3fa8dd3192ee2115ee739cc07 (diff) | |
download | dexon-sol-tools-8f2fd9b603f74aa8a44dc0e8c3b845d497f9b279.tar dexon-sol-tools-8f2fd9b603f74aa8a44dc0e8c3b845d497f9b279.tar.gz dexon-sol-tools-8f2fd9b603f74aa8a44dc0e8c3b845d497f9b279.tar.bz2 dexon-sol-tools-8f2fd9b603f74aa8a44dc0e8c3b845d497f9b279.tar.lz dexon-sol-tools-8f2fd9b603f74aa8a44dc0e8c3b845d497f9b279.tar.xz dexon-sol-tools-8f2fd9b603f74aa8a44dc0e8c3b845d497f9b279.tar.zst dexon-sol-tools-8f2fd9b603f74aa8a44dc0e8c3b845d497f9b279.zip |
Rename Signer to Wallet, rename GAS_ESTIMATE to GAS_LIMIT
-rw-r--r-- | packages/0x.js/test/global_hooks.ts | 2 | ||||
-rw-r--r-- | packages/contract-wrappers/test/global_hooks.ts | 2 | ||||
-rw-r--r-- | packages/contracts/src/contracts/current/protocol/Exchange/MixinSignatureValidator.sol | 4 | ||||
-rw-r--r-- | packages/contracts/src/contracts/current/protocol/Exchange/interfaces/IWallet.sol (renamed from packages/contracts/src/contracts/current/protocol/Exchange/interfaces/ISigner.sol) | 2 | ||||
-rw-r--r-- | packages/contracts/src/utils/web3_wrapper.ts | 2 | ||||
-rw-r--r-- | packages/dev-utils/src/constants.ts | 2 | ||||
-rw-r--r-- | packages/dev-utils/src/web3_factory.ts | 4 | ||||
-rw-r--r-- | packages/order-watcher/test/global_hooks.ts | 2 |
8 files changed, 10 insertions, 10 deletions
diff --git a/packages/0x.js/test/global_hooks.ts b/packages/0x.js/test/global_hooks.ts index d9768e61c..6d2c3219b 100644 --- a/packages/0x.js/test/global_hooks.ts +++ b/packages/0x.js/test/global_hooks.ts @@ -11,7 +11,7 @@ before('migrate contracts', async function(): Promise<void> { const mochaTestTimeoutMs = 20000; this.timeout(mochaTestTimeoutMs); const txDefaults = { - gas: devConstants.GAS_ESTIMATE, + gas: devConstants.GAS_LIMIT, from: devConstants.TESTRPC_FIRST_ADDRESS, }; const artifactsDir = `../migrations/artifacts/1.0.0`; diff --git a/packages/contract-wrappers/test/global_hooks.ts b/packages/contract-wrappers/test/global_hooks.ts index d9768e61c..6d2c3219b 100644 --- a/packages/contract-wrappers/test/global_hooks.ts +++ b/packages/contract-wrappers/test/global_hooks.ts @@ -11,7 +11,7 @@ before('migrate contracts', async function(): Promise<void> { const mochaTestTimeoutMs = 20000; this.timeout(mochaTestTimeoutMs); const txDefaults = { - gas: devConstants.GAS_ESTIMATE, + gas: devConstants.GAS_LIMIT, from: devConstants.TESTRPC_FIRST_ADDRESS, }; const artifactsDir = `../migrations/artifacts/1.0.0`; diff --git a/packages/contracts/src/contracts/current/protocol/Exchange/MixinSignatureValidator.sol b/packages/contracts/src/contracts/current/protocol/Exchange/MixinSignatureValidator.sol index 7f46766d6..7f4e20b5b 100644 --- a/packages/contracts/src/contracts/current/protocol/Exchange/MixinSignatureValidator.sol +++ b/packages/contracts/src/contracts/current/protocol/Exchange/MixinSignatureValidator.sol @@ -20,7 +20,7 @@ pragma solidity ^0.4.24; import "./mixins/MSignatureValidator.sol"; import "./mixins/MTransactions.sol"; -import "./interfaces/ISigner.sol"; +import "./interfaces/IWallet.sol"; import "./interfaces/IValidator.sol"; import "./libs/LibExchangeErrors.sol"; import "../../utils/LibBytes/LibBytes.sol"; @@ -168,7 +168,7 @@ contract MixinSignatureValidator is // Signature verified by wallet contract. // If used with an order, the maker of the order is the wallet contract. } else if (signatureType == SignatureType.Wallet) { - isValid = ISigner(signer).isValidSignature(hash, signature); + isValid = IWallet(signer).isValidSignature(hash, signature); return isValid; // Signature verified by validator contract. diff --git a/packages/contracts/src/contracts/current/protocol/Exchange/interfaces/ISigner.sol b/packages/contracts/src/contracts/current/protocol/Exchange/interfaces/IWallet.sol index 0186ad490..c86a2c057 100644 --- a/packages/contracts/src/contracts/current/protocol/Exchange/interfaces/ISigner.sol +++ b/packages/contracts/src/contracts/current/protocol/Exchange/interfaces/IWallet.sol @@ -18,7 +18,7 @@ pragma solidity ^0.4.24; -contract ISigner { +contract IWallet { /// @dev Verifies that a signature is valid. /// @param hash Message hash that is signed. diff --git a/packages/contracts/src/utils/web3_wrapper.ts b/packages/contracts/src/utils/web3_wrapper.ts index 02595506b..4b8512222 100644 --- a/packages/contracts/src/utils/web3_wrapper.ts +++ b/packages/contracts/src/utils/web3_wrapper.ts @@ -7,7 +7,7 @@ import { coverage } from './coverage'; export const txDefaults = { from: devConstants.TESTRPC_FIRST_ADDRESS, - gas: devConstants.GAS_ESTIMATE, + gas: devConstants.GAS_LIMIT, }; const providerConfigs = { shouldUseInProcessGanache: true }; export const provider = web3Factory.getRpcProvider(providerConfigs); diff --git a/packages/dev-utils/src/constants.ts b/packages/dev-utils/src/constants.ts index 48efd62cc..56e87d764 100644 --- a/packages/dev-utils/src/constants.ts +++ b/packages/dev-utils/src/constants.ts @@ -1,6 +1,6 @@ export const constants = { RPC_URL: 'http://localhost:8545', RPC_PORT: 8545, - GAS_ESTIMATE: 8000000, + GAS_LIMIT: 7000000, TESTRPC_FIRST_ADDRESS: '0x5409ed021d9299bf6814279a6a1411a7e866a631', }; diff --git a/packages/dev-utils/src/web3_factory.ts b/packages/dev-utils/src/web3_factory.ts index 98fccd835..c273035da 100644 --- a/packages/dev-utils/src/web3_factory.ts +++ b/packages/dev-utils/src/web3_factory.ts @@ -28,7 +28,7 @@ export const web3Factory = { if (!hasAddresses) { provider.addProvider(new EmptyWalletSubprovider()); } - provider.addProvider(new FakeGasEstimateSubprovider(constants.GAS_ESTIMATE)); + provider.addProvider(new FakeGasEstimateSubprovider(constants.GAS_LIMIT)); const logger = { log: (arg: any) => { fs.appendFileSync('ganache.log', `${arg}\n`); @@ -41,7 +41,7 @@ export const web3Factory = { } provider.addProvider( new GanacheSubprovider({ - gasLimit: constants.GAS_ESTIMATE, + gasLimit: constants.GAS_LIMIT, logger, verbose: env.parseBoolean(EnvVars.VerboseGanache), port: 8545, diff --git a/packages/order-watcher/test/global_hooks.ts b/packages/order-watcher/test/global_hooks.ts index 1df80533c..3d3f0e474 100644 --- a/packages/order-watcher/test/global_hooks.ts +++ b/packages/order-watcher/test/global_hooks.ts @@ -12,7 +12,7 @@ before('migrate contracts', async function(): Promise<void> { const mochaTestTimeoutMs = 20000; this.timeout(mochaTestTimeoutMs); const txDefaults = { - gas: devConstants.GAS_ESTIMATE, + gas: devConstants.GAS_LIMIT, from: devConstants.TESTRPC_FIRST_ADDRESS, }; const artifactsDir = `../migrations/artifacts/1.0.0`; |