diff options
author | Fabio Berger <me@fabioberger.com> | 2017-05-30 18:32:13 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-05-30 18:32:13 +0800 |
commit | 73ae3df172b1fdb7e6a3f5cbb866b09fb5f9d032 (patch) | |
tree | 5e09a057da737463c833232727335de37757bc77 | |
parent | c536114b1638e30e5053dfc33d8e16465c0d373c (diff) | |
parent | 220f92541545851abda885df196be790e08fe040 (diff) | |
download | dexon-sol-tools-73ae3df172b1fdb7e6a3f5cbb866b09fb5f9d032.tar dexon-sol-tools-73ae3df172b1fdb7e6a3f5cbb866b09fb5f9d032.tar.gz dexon-sol-tools-73ae3df172b1fdb7e6a3f5cbb866b09fb5f9d032.tar.bz2 dexon-sol-tools-73ae3df172b1fdb7e6a3f5cbb866b09fb5f9d032.tar.lz dexon-sol-tools-73ae3df172b1fdb7e6a3f5cbb866b09fb5f9d032.tar.xz dexon-sol-tools-73ae3df172b1fdb7e6a3f5cbb866b09fb5f9d032.tar.zst dexon-sol-tools-73ae3df172b1fdb7e6a3f5cbb866b09fb5f9d032.zip |
Merge pull request #22 from 0xProject/regex-fix
Fix the empty code regex
-rw-r--r-- | src/web3_wrapper.ts | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/web3_wrapper.ts b/src/web3_wrapper.ts index 97d04db8c..a915a89e8 100644 --- a/src/web3_wrapper.ts +++ b/src/web3_wrapper.ts @@ -49,10 +49,9 @@ export class Web3Wrapper { } public async doesContractExistAtAddressAsync(address: string): Promise<boolean> { const code = await promisify(this.web3.eth.getCode)(address); - // Regex matches 0x0, 0x00, 0x in order to accomodate poorly implemented clients - const zeroHexAddressRegex = /^0x0*$/i; - const didFindCode = _.isNull(code.match(zeroHexAddressRegex)); - return didFindCode; + // Regex matches 0x0, 0x00, 0x in order to accommodate poorly implemented clients + const codeIsEmpty = /^0x0{0,40}$/i.test(code); + return !codeIsEmpty; } public async signTransactionAsync(address: string, message: string): Promise<string> { const signData = await promisify(this.web3.eth.sign)(address, message); |