diff options
| author | Leonid Logvinov <logvinov.leon@gmail.com> | 2017-08-25 02:35:27 +0800 |
|---|---|---|
| committer | Leonid Logvinov <logvinov.leon@gmail.com> | 2017-08-25 04:48:51 +0800 |
| commit | bd67cf0f9f9bf321848d2dd929fcd474e236cee7 (patch) | |
| tree | 5a42dfeb34cce4dc67ca1bf4a7d484deda64bb1a | |
| parent | 5a3a8ae7d5867a0304fbb1368dc1f2d018e14ac5 (diff) | |
| download | dexon-sol-tools-bd67cf0f9f9bf321848d2dd929fcd474e236cee7.tar dexon-sol-tools-bd67cf0f9f9bf321848d2dd929fcd474e236cee7.tar.gz dexon-sol-tools-bd67cf0f9f9bf321848d2dd929fcd474e236cee7.tar.bz2 dexon-sol-tools-bd67cf0f9f9bf321848d2dd929fcd474e236cee7.tar.lz dexon-sol-tools-bd67cf0f9f9bf321848d2dd929fcd474e236cee7.tar.xz dexon-sol-tools-bd67cf0f9f9bf321848d2dd929fcd474e236cee7.tar.zst dexon-sol-tools-bd67cf0f9f9bf321848d2dd929fcd474e236cee7.zip | |
Improve comments
| -rw-r--r-- | src/contract_wrappers/token_wrapper.ts | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/contract_wrappers/token_wrapper.ts b/src/contract_wrappers/token_wrapper.ts index 0c89d4e9b..a2812ccdb 100644 --- a/src/contract_wrappers/token_wrapper.ts +++ b/src/contract_wrappers/token_wrapper.ts @@ -83,6 +83,8 @@ export class TokenWrapper extends ContractWrapper { /** * Sets the spender's allowance to an unlimited number of baseUnits on behalf of the owner address. * Equivalent to the ERC20 spec method `approve`. + * Setting an unlimited allowance will lower the gas cost for filling orders involving tokens that forego updating + * allowances set to the max amount (e.g ZRX, WETH) * @param tokenAddress The hex encoded contract Ethereum address where the ERC20 token is deployed. * @param ownerAddress The hex encoded user Ethereum address who would like to set an allowance * for spenderAddress. @@ -144,6 +146,8 @@ export class TokenWrapper extends ContractWrapper { /** * Sets the 0x proxy contract's allowance to a unlimited number of a tokens' baseUnits on behalf * of an owner address. + * Setting an unlimited allowance will lower the gas cost for filling orders involving tokens that forego updating + * allowances set to the max amount (e.g ZRX, WETH) * @param tokenAddress The hex encoded contract Ethereum address where the ERC20 token is deployed. * @param ownerAddress The hex encoded user Ethereum address who is setting an allowance * for the Proxy contract. |