aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSteve Klebanoff <steve@0xproject.com>2018-12-06 12:11:23 +0800
committerGitHub <noreply@github.com>2018-12-06 12:11:23 +0800
commitc18561822475fa6c97ed0135ed68b10be9886a9f (patch)
tree3d40eb975a441fe393e5dd8019871e3cf5574a79
parentcae0e02bc655ba8ea3a8788328c4da471db1eac0 (diff)
parentb0e7b82dd99f5411fc77cd4368faf22506de4b11 (diff)
downloaddexon-sol-tools-c18561822475fa6c97ed0135ed68b10be9886a9f.tar
dexon-sol-tools-c18561822475fa6c97ed0135ed68b10be9886a9f.tar.gz
dexon-sol-tools-c18561822475fa6c97ed0135ed68b10be9886a9f.tar.bz2
dexon-sol-tools-c18561822475fa6c97ed0135ed68b10be9886a9f.tar.lz
dexon-sol-tools-c18561822475fa6c97ed0135ed68b10be9886a9f.tar.xz
dexon-sol-tools-c18561822475fa6c97ed0135ed68b10be9886a9f.tar.zst
dexon-sol-tools-c18561822475fa6c97ed0135ed68b10be9886a9f.zip
Merge pull request #1398 from 0xProject/feature/instant/more-error-reporting
[instant] More aggressive error reporting
-rw-r--r--packages/instant/src/util/buy_quote_updater.ts7
1 files changed, 2 insertions, 5 deletions
diff --git a/packages/instant/src/util/buy_quote_updater.ts b/packages/instant/src/util/buy_quote_updater.ts
index 4229f2735..6191c92e3 100644
--- a/packages/instant/src/util/buy_quote_updater.ts
+++ b/packages/instant/src/util/buy_quote_updater.ts
@@ -38,14 +38,11 @@ export const buyQuoteUpdater = {
} catch (error) {
const errorMessage = assetUtils.assetBuyerErrorMessage(asset, error);
- if (_.isUndefined(errorMessage)) {
- // This is an unknown error, report it to rollbar
- errorReporter.report(error);
- }
+ errorReporter.report(error);
+ analytics.trackQuoteError(error.message ? error.message : 'other', baseUnitValue, fetchOrigin);
if (options.dispatchErrors) {
dispatch(actions.setQuoteRequestStateFailure());
- analytics.trackQuoteError(error.message ? error.message : 'other', baseUnitValue, fetchOrigin);
errorFlasher.flashNewErrorMessage(dispatch, errorMessage || 'Error fetching price, please try again');
}
return;