From 49c47180328c06eaeaca9176c2819b55bd75464f Mon Sep 17 00:00:00 2001 From: Mission Liao Date: Fri, 22 Mar 2019 14:04:30 +0800 Subject: core: height event handlers are not called (#509) * Make utils.RoundEvent.ValidateNextRound non-blocking * Make NotifyHeight called blockingly * Trigger all height event handlers that should be triggered by initBlock * Fixup: forget the syncer part --- core/test/app_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'core/test/app_test.go') diff --git a/core/test/app_test.go b/core/test/app_test.go index 138f803..e06b758 100644 --- a/core/test/app_test.go +++ b/core/test/app_test.go @@ -309,7 +309,7 @@ func (s *AppTestSuite) TestAttachedWithRoundEvent() { 1900, 2019, core.ConfigRoundShift) s.Require().NoError(err) // Register a handler to collects triggered events. - evts := make(chan evtParamToCheck, 2) + evts := make(chan evtParamToCheck, 3) rEvt.Register(func(params []utils.RoundEventParam) { for _, p := range params { evts <- evtParamToCheck{ @@ -336,6 +336,7 @@ func (s *AppTestSuite) TestAttachedWithRoundEvent() { // Deliver blocks from height=2020 to height=2081. deliver(0, 0, 2019) deliver(19, 2020, 2091) + s.Require().Equal(<-evts, evtParamToCheck{19, 1, 2000, gov.CRS(19)}) s.Require().Equal(<-evts, evtParamToCheck{19, 2, 2100, gov.CRS(19)}) s.Require().Equal(<-evts, evtParamToCheck{20, 0, 2200, gov.CRS(20)}) // Deliver blocks from height=2082 to height=2281. -- cgit v1.2.3