core: Fix a bug of DKGNackComplaints (#370)

* core: Fix a bug if DKGNackComplaint is added after required time.

* Duplicated NackComplaint should be only count once.

1 files changed, 9 insertions, 4 deletions

diff --git a/core/dkg-tsig-protocol.go b/core/dkg-tsig-protocol.go
index 6645ecb..8e03cbb 100644
--- a/core/dkg-tsig-protocol.go
+++ b/core/dkg-tsig-protocol.go
@@ -378,16 +378,21 @@ func NewDKGGroupPublicKey(
 
 	// Calculate qualify members.
 	disqualifyIDs := map[types.NodeID]struct{}{}
-	complaintsByID := map[types.NodeID]int{}
+	complaintsByID := map[types.NodeID]map[types.NodeID]struct{}{}
 	for _, complaint := range complaints {
 		if complaint.IsNack() {
-			complaintsByID[complaint.PrivateShare.ProposerID]++
+			if _, exist := complaintsByID[complaint.PrivateShare.ProposerID]; !exist {
+				complaintsByID[complaint.PrivateShare.ProposerID] =
+					make(map[types.NodeID]struct{})
+			}
+			complaintsByID[complaint.PrivateShare.ProposerID][complaint.ProposerID] =
+				struct{}{}
 		} else {
 			disqualifyIDs[complaint.PrivateShare.ProposerID] = struct{}{}
 		}
 	}
-	for nID, num := range complaintsByID {
-		if num > threshold {
+	for nID, complaints := range complaintsByID {
+		if len(complaints) > threshold {
 			disqualifyIDs[nID] = struct{}{}
 		}
 	}