From 5b33a863f08bbd60d7631bd586e00c993f8cda1e Mon Sep 17 00:00:00 2001
From: MITSUNARI Shigeo <herumi@nifty.com>
Date: Tue, 18 Sep 2018 07:21:07 +0900
Subject: add comment for verifyAggregateTest

---
 test/bls_test.hpp | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/test/bls_test.hpp b/test/bls_test.hpp
index bb58ad2..62ef0eb 100644
--- a/test/bls_test.hpp
+++ b/test/bls_test.hpp
@@ -426,7 +426,7 @@ void dataTest()
 	}
 }
 
-void verifyAggregateTest()
+void verifyAggregateTest(int type)
 {
 	const size_t n = 10;
 	bls::SecretKey secs[n];
@@ -455,10 +455,19 @@ void verifyAggregateTest()
 	bls::Signature invalidSig = sigs[0] + sigs[1];
 	CYBOZU_TEST_ASSERT(!invalidSig.verifyAggregatedHashes(pubs, h.data(), sizeofHash, n));
 	h[0][0]++;
-	CYBOZU_TEST_ASSERT(!sig.verifyAggregatedHashes(pubs, h.data(), sizeofHash, n));
+	if (type == MCL_BLS12_381) {
+		/*
+			CAUTION!!!
+			BN::mapToG1 called in blsG1SetHash(h) may return same point for different h.
+			especially, maptG1(h) may be equal to mapG1(h') such as |h - h'| < small value for BLS12_381.
+		*/
+		CYBOZU_TEST_ASSERT(sig.verifyAggregatedHashes(pubs, h.data(), sizeofHash, n));
+	} else {
+		CYBOZU_TEST_ASSERT(!sig.verifyAggregatedHashes(pubs, h.data(), sizeofHash, n));
+	}
 }
 
-void testAll()
+void testAll(int type)
 {
 	blsTest();
 	k_of_nTest();
@@ -466,7 +475,7 @@ void testAll()
 	addTest();
 	dataTest();
 	aggregateTest();
-	verifyAggregateTest();
+	verifyAggregateTest(type);
 }
 CYBOZU_TEST_AUTO(all)
 {
@@ -487,7 +496,7 @@ CYBOZU_TEST_AUTO(all)
 		if (type == MCL_BN254) {
 			testForBN254();
 		}
-		testAll();
+		testAll(type);
 		hashTest(type);
 	}
 }
-- 
cgit v1.2.3