From 45e9fbe8f93f68f3786629fff1861b1a66b90635 Mon Sep 17 00:00:00 2001 From: Jacob Evans Date: Tue, 31 Jul 2018 17:24:19 +0800 Subject: Introduce SignerProviderType This allows the developer to indicate the nuanced signer provider. Some have different implementations (trezor, ledger) and others have different implementations (metamask). Breaking the abstraction of eth_sign. EthSign assumes a spec compliant implementation and can be used as a default --- packages/types/src/index.ts | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'packages/types/src') diff --git a/packages/types/src/index.ts b/packages/types/src/index.ts index 7774b61b0..ba384dbb8 100644 --- a/packages/types/src/index.ts +++ b/packages/types/src/index.ts @@ -142,6 +142,16 @@ export enum SignatureType { NSignatureTypes, } +/** + * The Signer Provider Type. Some Signer implementations use different message prefixes or implement different + * eth_sign behaviour. Note EthSign is compatible with the Ledger device. + */ +export enum SignerProviderType { + EthSign = 'ETH_SIGN', + Metamask = 'METAMASK', + Trezor = 'TREZOR', +} + /** * Elliptic Curve signature */ -- cgit v1.2.3 From 5d4dd406f2946b43377049d7422c72b433bc64ab Mon Sep 17 00:00:00 2001 From: Jacob Evans Date: Fri, 3 Aug 2018 11:53:26 +0800 Subject: Update Changelogs. Rebased from development --- packages/types/src/index.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'packages/types/src') diff --git a/packages/types/src/index.ts b/packages/types/src/index.ts index ba384dbb8..58399de4c 100644 --- a/packages/types/src/index.ts +++ b/packages/types/src/index.ts @@ -143,11 +143,12 @@ export enum SignatureType { } /** - * The Signer Provider Type. Some Signer implementations use different message prefixes or implement different - * eth_sign behaviour. Note EthSign is compatible with the Ledger device. + * The Signer Provider Type. Some Signer provider implementations use different message prefixes or implement different + * eth_sign behaviour. */ export enum SignerProviderType { EthSign = 'ETH_SIGN', + Ledger = 'LEDGER', Metamask = 'METAMASK', Trezor = 'TREZOR', } -- cgit v1.2.3 From ca4905c3436931684d113ec66882836a4d0b265b Mon Sep 17 00:00:00 2001 From: Jacob Evans Date: Thu, 9 Aug 2018 12:24:52 +1000 Subject: Rename from SignerProviderType.EthSign to SignerType.Default --- packages/types/src/index.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'packages/types/src') diff --git a/packages/types/src/index.ts b/packages/types/src/index.ts index 58399de4c..fa634420d 100644 --- a/packages/types/src/index.ts +++ b/packages/types/src/index.ts @@ -143,11 +143,11 @@ export enum SignatureType { } /** - * The Signer Provider Type. Some Signer provider implementations use different message prefixes or implement different - * eth_sign behaviour. + * The type of the Signer implementation. Some signer implementations use different message prefixes (e.g Trezor) or implement different + * eth_sign behaviour (e.g Metamask). Default assumes a spec compliant `eth_sign`. */ -export enum SignerProviderType { - EthSign = 'ETH_SIGN', +export enum SignerType { + Default = 'DEFAULT', Ledger = 'LEDGER', Metamask = 'METAMASK', Trezor = 'TREZOR', -- cgit v1.2.3