From 89202b7bdffe084511971e331f81dd5878f2a56c Mon Sep 17 00:00:00 2001 From: "F. Eugene Aumson" Date: Wed, 15 Aug 2018 16:01:57 -0700 Subject: clarify recompilation tests --- packages/sol-compiler/test/compiler_test.ts | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/packages/sol-compiler/test/compiler_test.ts b/packages/sol-compiler/test/compiler_test.ts index 08799c14b..7e22ff0ef 100644 --- a/packages/sol-compiler/test/compiler_test.ts +++ b/packages/sol-compiler/test/compiler_test.ts @@ -64,7 +64,7 @@ describe('#Compiler', function(): void { describe('after a successful compilation', () => { const contract = 'Exchange'; let artifactPath: string; - let timeCompiled: number; + let compilationTimestamp: number; beforeEach(async () => { compilerOpts.contracts = [contract]; @@ -75,23 +75,25 @@ describe('#Compiler', function(): void { await new Compiler(compilerOpts).compileAsync(); - timeCompiled = (await fsWrapper.statAsync(artifactPath)).mtimeMs; + compilationTimestamp = (await fsWrapper.statAsync(artifactPath)).mtimeMs; }); it('recompilation should update artifact when source has changed', async () => { + // append some meaningless data to the contract, so that its hash + // will change, so that the compiler will decide to recompile it. fsWrapper.appendFileAsync(join(contractsDir, `${contract}.sol`), ' '); await new Compiler(compilerOpts).compileAsync(); - const timeRecompiled = (await fsWrapper.statAsync(artifactPath)).mtimeMs; + const recompilationTimestamp = (await fsWrapper.statAsync(artifactPath)).mtimeMs; - expect(timeRecompiled).to.not.equal(timeCompiled); + expect(recompilationTimestamp).to.be.greaterThan(compilationTimestamp); }); it("recompilation should NOT update artifact when source hasn't changed", async () => { await new Compiler(compilerOpts).compileAsync(); - const timeRecompiled = (await fsWrapper.statAsync(artifactPath)).mtimeMs; + const recompilationTimestamp = (await fsWrapper.statAsync(artifactPath)).mtimeMs; - expect(timeRecompiled).to.equal(timeCompiled); + expect(recompilationTimestamp).to.equal(compilationTimestamp); }); }); it('should only compile what was requested', async () => { -- cgit v1.2.3