From 67fbffc964a12c56c06e3262c9afdb1d2d01559c Mon Sep 17 00:00:00 2001 From: Fabio Berger Date: Tue, 13 Mar 2018 16:55:35 +0100 Subject: Re-add linter to monorepo-scripts but with tslint-config dep at earlier version to avoid cyclical dependency --- packages/monorepo-scripts/package.json | 2 ++ packages/monorepo-scripts/tslint.json | 3 +++ yarn.lock | 7 +++++++ 3 files changed, 12 insertions(+) create mode 100644 packages/monorepo-scripts/tslint.json diff --git a/packages/monorepo-scripts/package.json b/packages/monorepo-scripts/package.json index 42b9d6c55..e0ca3cd1f 100644 --- a/packages/monorepo-scripts/package.json +++ b/packages/monorepo-scripts/package.json @@ -20,7 +20,9 @@ "url": "https://github.com/0xProject/0x-monorepo/issues" }, "homepage": "https://github.com/0xProject/0x-monorepo/packages/monorepo-scripts/README.md", + "comment": "// We purposefully use an older version of tslint-config here to avoid creating an import cycle", "devDependencies": { + "@0xproject/tslint-config": "0.4.8", "@types/glob": "^5.0.33", "@types/node": "^8.0.53", "shx": "^0.2.2", diff --git a/packages/monorepo-scripts/tslint.json b/packages/monorepo-scripts/tslint.json new file mode 100644 index 000000000..ffaefe83a --- /dev/null +++ b/packages/monorepo-scripts/tslint.json @@ -0,0 +1,3 @@ +{ + "extends": ["@0xproject/tslint-config"] +} diff --git a/yarn.lock b/yarn.lock index 88532729b..821a22f10 100644 --- a/yarn.lock +++ b/yarn.lock @@ -6,6 +6,13 @@ version "0.3.9" resolved "https://registry.yarnpkg.com/8fold-marked/-/8fold-marked-0.3.9.tgz#bb89c645612f8ccfaffac1ca6e3c11f168c9cf59" +"@0xproject/tslint-config@0.4.8": + version "0.4.8" + resolved "https://registry.yarnpkg.com/@0xproject/tslint-config/-/tslint-config-0.4.8.tgz#5a3dfb1fc94e17752184137b452c5b0b3287d822" + dependencies: + lodash "^4.17.4" + tslint-react "^3.2.0" + "@ledgerhq/hw-app-eth@^4.3.0": version "4.3.0" resolved "https://registry.yarnpkg.com/@ledgerhq/hw-app-eth/-/hw-app-eth-4.3.0.tgz#5f365a3560cd78e8cd711737ec56249390cbf5e5" -- cgit v1.2.3