aboutsummaryrefslogtreecommitdiffstats
path: root/packages
diff options
context:
space:
mode:
authorJacob Evans <jacob@dekz.net>2018-02-27 05:41:03 +0800
committerJacob Evans <jacob@dekz.net>2018-02-27 10:10:27 +0800
commit3d66feb89f8e4cfcb0b5251a96d02ef31f3ae34b (patch)
treeb95fa26a1b8f8b22a792038502374f0a09624240 /packages
parenteabe96fd194f21b1c670381506b115589a37eff5 (diff)
downloaddexon-0x-contracts-3d66feb89f8e4cfcb0b5251a96d02ef31f3ae34b.tar
dexon-0x-contracts-3d66feb89f8e4cfcb0b5251a96d02ef31f3ae34b.tar.gz
dexon-0x-contracts-3d66feb89f8e4cfcb0b5251a96d02ef31f3ae34b.tar.bz2
dexon-0x-contracts-3d66feb89f8e4cfcb0b5251a96d02ef31f3ae34b.tar.lz
dexon-0x-contracts-3d66feb89f8e4cfcb0b5251a96d02ef31f3ae34b.tar.xz
dexon-0x-contracts-3d66feb89f8e4cfcb0b5251a96d02ef31f3ae34b.tar.zst
dexon-0x-contracts-3d66feb89f8e4cfcb0b5251a96d02ef31f3ae34b.zip
Lowercase web3 wrapper addresses
Ensure all of the user account addresses are lower case when returned from web3wrapper
Diffstat (limited to 'packages')
-rw-r--r--packages/web3-wrapper/CHANGELOG.md6
-rw-r--r--packages/web3-wrapper/src/index.ts6
2 files changed, 9 insertions, 3 deletions
diff --git a/packages/web3-wrapper/CHANGELOG.md b/packages/web3-wrapper/CHANGELOG.md
index eb31f7e3c..e51366e6f 100644
--- a/packages/web3-wrapper/CHANGELOG.md
+++ b/packages/web3-wrapper/CHANGELOG.md
@@ -1,5 +1,9 @@
# CHANGELOG
-## v0.1.12 _February 9, 2018_
+## v0.2.XX - _TBD_ 2018
+
+ * Ensure all returned user addresses are lowercase (#373)
+
+## v0.1.12 - _February 9, 2018_
* Fix publishing issue where .npmignore was not properly excluding undesired content (#389)
diff --git a/packages/web3-wrapper/src/index.ts b/packages/web3-wrapper/src/index.ts
index a2878fc2a..7f3452c98 100644
--- a/packages/web3-wrapper/src/index.ts
+++ b/packages/web3-wrapper/src/index.ts
@@ -41,7 +41,8 @@ export class Web3Wrapper {
}
public async isSenderAddressAvailableAsync(senderAddress: string): Promise<boolean> {
const addresses = await this.getAvailableAddressesAsync();
- return _.includes(addresses, senderAddress);
+ const normalizedAddress = senderAddress.toLowerCase();
+ return _.includes(addresses, normalizedAddress);
}
public async getNodeVersionAsync(): Promise<string> {
const nodeVersion = await promisify<string>(this._web3.version.getNode)();
@@ -96,7 +97,8 @@ export class Web3Wrapper {
}
public async getAvailableAddressesAsync(): Promise<string[]> {
const addresses = await promisify<string[]>(this._web3.eth.getAccounts)();
- return addresses;
+ const normalizedAddresses = _.map(addresses, address => address.toLowerCase());
+ return normalizedAddresses;
}
public async getLogsAsync(filter: Web3.FilterObject): Promise<Web3.LogEntry[]> {
let fromBlock = filter.fromBlock;